Fix integration discovery and options lookup - #84
Conversation
|
CodeAnt AI is reviewing your PR. |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughSpecial-case discovery-prefixed mount paths, add Relayfile remote directory listing and IPC/preload surface, compute agent-workspace discovery (+ optional historical) mount paths and sync them deduplicated per provider, gate the mount-browser UI on historical-download capability, update Slack channel listing flow, and add tests for discovery mounts and remount timing. ChangesDiscovery Mount Paths and Conditional Historical Browsing
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes
Note 🎁 Summarized by CodeRabbit FreeYour organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login. Comment |
codeant-ai
Bot
added
the
size:L
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces support for writeback discovery mounts for connected integrations, ensuring root-level discovery paths are preserved and handled correctly. It also refactors integration options fetching, updates UI settings to restrict browsing to integrations with historical download enabled, and adjusts Slack channel option retrieval. However, a potential regression was identified in src/main/integrations.ts where removing the try-catch block for handling 404 errors in listOptions could cause unhandled exceptions to propagate to the UI.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| const payload = await this.withWorkspaceHandle(async (handle) => await handle.requestJson({ | ||
| operation: 'listIntegrationOptions', | ||
| method: 'GET', | ||
| path: `api/v1/workspaces/${handle.workspaceId}/integrations/${encodeURIComponent(normalizedProvider)}/options/${encodeURIComponent(normalizedResource)}` | ||
| }) as unknown) |
There was a problem hiding this comment.
Removing the try-catch block that handles 404 errors is a regression. If the integration options endpoint is not found or not implemented for a specific provider, handle.requestJson will throw a 404 error, causing listOptions to fail and propagate an unhandled exception to the UI. Restoring the 404 error handling to return an empty array [] ensures robustness and prevents UI crashes.
let payload: unknown
try {
payload = await this.withWorkspaceHandle(async (handle) => await handle.requestJson({
operation: 'listIntegrationOptions',
method: 'GET',
path: `api/v1/workspaces/${handle.workspaceId}/integrations/${encodeURIComponent(normalizedProvider)}/options/${encodeURIComponent(normalizedResource)}`
}) as unknown)
} catch (error) {
if (isHttpStatus(error, 404) || /\b404\b/u.test(toErrorMessage(error))) return []
throw error
}
|
CodeAnt AI finished reviewing your PR. |
|
Fixed the PR issues I found. Changes made:
Local verification passed:
|
|
✅ pr-reviewer applied fixes — committed and pushed Fixed the PR issues I found. Changes made:
Local verification passed:
|
|
Fixed the PR issue I found: discovery mounts are now surfaced in Local verification passed:
|
|
✅ pr-reviewer applied fixes — committed and pushed Fixed the PR issue I found: discovery mounts are now surfaced in Local verification passed:
|
|
Reviewed the PR artifacts and traced the helper through the cloud-agent box and proactive-runtime callers. Fixed one real gap in the PR: warmed clones fetched refs correctly, but cold clones still used Local checks run:
|
|
✅ pr-reviewer applied fixes — committed and pushed Fixed the PR issue I found: discovery mounts are now surfaced in Local verification passed:
|
|
Fixed the PR issues I found:
Local verification run:
|
|
✅ pr-reviewer applied fixes — committed and pushed Fixed the PR issues I found:
Local verification run:
|
|
Fixed the PR issues I found. Changed src/main/integrations.ts to:
Added focused coverage in src/main/integrations.test.ts. Local checks run:
|
1 similar comment
|
Fixed the PR issues I found. Changed src/main/integrations.ts to:
Added focused coverage in src/main/integrations.test.ts. Local checks run:
|
|
Fixed a PR regression in src/main/integrations.ts: discovery mount paths are now preserved as Local checks run:
|
|
✅ pr-reviewer applied fixes — committed and pushed Fixed a PR regression in src/main/integrations.ts: discovery mount paths are now preserved as Local checks run:
|
|
Reviewed and fixed PR #84 locally. Fixed:
Local verification passed:
|
|
Fixed the Slack channel picker regression in the PR. Changes made:
Local verification passed:
|
|
Fixed the Slack channel picker regression in the PR. Changes made:
Local verification passed:
|
|
Fixed a remote directory scope leak in PR #84: selected Slack channel scopes can no longer enumerate the parent Local checks run:
|
|
✅ pr-reviewer applied fixes — committed and pushed Fixed a remote directory scope leak in PR #84: selected Slack channel scopes can no longer enumerate the parent Local checks run:
|
|
CodeAnt AI is running Incremental review |
codeant-ai
Bot
added
size:XL
|
CodeAnt AI Incremental review completed. |
|
Reviewed PR #84 and fixed the remote directory listing regression. Changed:
Verified locally:
|
2 participants
User description
Summary
listRemoteDir(projectId, remotePath)IPC API backed by RelayfilelistTree, so integration pickers can read already-synced remote data without local mounts/slack/channelsas the Slack picker fallback before local filesystem mountsTests
CodeAnt-AI Description
Use remote integration data for Slack pickers and discovery paths
What Changed
Impact
✅ Fewer blocked Slack channel pickers✅ Clearer access to synced vs discovery data✅ Fewer empty integration browsers🔄 Retrigger CodeAnt AI Review
💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.