PR #1502 (#1502, branch fix/fleet-attach-workspace-key) adds --workspace-key to node agent attach --node. Two reviewers (CodeRabbit, cubic-dev-ai) flagged the same real gap, still unaddressed as of 2026-08-14 06:00Z:
- A whitespace-only --workspace-key value supplied WITHOUT --node is currently treated as absent instead of rejected. In packages/cli/src/cli/commands/local-agent.ts (~line 612-625, may have shifted), the guard needs to check whether the raw --workspace-key option was present at all when --node is absent, and reject with the existing error. On the --node path, keep normalizing blank to undefined (unchanged, already correct). Add test coverage for the blank-without---node case, both local-broker and --ssh-host paths.
- (cubic only) The rejection error message tells --ssh-host users to use --broker-url/--api-key, but that combo is actually rejected on the ssh-host path (it wants --state-dir instead) — fix the message to give path-appropriate guidance.
Red-check required: new/changed tests must fail pre-fix, pass post-fix. Push to origin fix/fleet-attach-workspace-key (the existing PR branch, do not open a new PR). Reply-and-resolve the actual GitHub review threads as proof of fix, not just push and claim done.
PR #1502 (#1502, branch fix/fleet-attach-workspace-key) adds --workspace-key to node agent attach --node. Two reviewers (CodeRabbit, cubic-dev-ai) flagged the same real gap, still unaddressed as of 2026-08-14 06:00Z:
Red-check required: new/changed tests must fail pre-fix, pass post-fix. Push to origin fix/fleet-attach-workspace-key (the existing PR branch, do not open a new PR). Reply-and-resolve the actual GitHub review threads as proof of fix, not just push and claim done.