-
Notifications
You must be signed in to change notification settings - Fork 66
fix(cli): use workspace authentication for provider subscriptions #1834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
fc32a41
fix(cli): use workspace auth for provider subscription lifecycle
khaliqgant 59c4039
style: auto-format with Prettier
github-actions[bot] 5ca0ccf
docs: record exact live PR owner subscription bindings
khaliqgant 813d489
fix(cli): reject subscription token options before provider work
khaliqgant 064efa7
Merge remote-tracking branch 'origin/main' into repair/pr1834-subscri…
93155f3
Merge remote-tracking branch 'origin/main' into repair/pr1834-current
a98704a
docs: correct workspace key evidence name
bcf5999
style: auto-format with Prettier
github-actions[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| [ | ||
| { | ||
| "provider": "github", | ||
| "resource": "/github/repos/AgentWorkforce/cloud/pulls/3896/**", | ||
| "channel": "agent-events-227666016525594624", | ||
| "webhookId": "wh_227668032397963264", | ||
| "subscriptionId": "sub_227668035883429888", | ||
| "webhookSubscriptionId": "whsub_9171d549-7f7a-4ae5-a340-bc1c01dba11b", | ||
| "webhookSubscriptionWorkspaceId": "rw_7ccfea89" | ||
| }, | ||
| { | ||
| "provider": "github", | ||
| "resource": "/github/repos/AgentWorkforce/relay/pulls/1834/**", | ||
| "channel": "agent-events-227666016525594624", | ||
| "webhookId": "wh_227674523242795008", | ||
| "subscriptionId": "sub_227674526870867968", | ||
| "webhookSubscriptionId": "whsub_74bb3bec-bf6e-4953-86af-4c3e1ef7d0b8", | ||
| "webhookSubscriptionWorkspaceId": "rw_7ccfea89" | ||
| }, | ||
| { | ||
| "provider": "github", | ||
| "resource": "/github/repos/AgentWorkforce/relayfile-cloud/pulls/238/**", | ||
| "channel": "agent-events-227666016525594624", | ||
| "webhookId": "wh_227669931394633728", | ||
| "subscriptionId": "sub_227669934972375040", | ||
| "webhookSubscriptionId": "whsub_d1a74cda-3a57-45cf-882d-70e24b4d9fb0", | ||
| "webhookSubscriptionWorkspaceId": "rw_7ccfea89" | ||
| }, | ||
| { | ||
| "provider": "github", | ||
| "resource": "/github/repos/AgentWorkforce/relayfile/pulls/515/**", | ||
| "channel": "agent-events-227666016525594624", | ||
| "webhookId": "wh_227673937327886336", | ||
| "subscriptionId": "sub_227673941069205504", | ||
| "webhookSubscriptionId": "whsub_45079f6f-a330-46d9-b9b7-b167834cf253", | ||
| "webhookSubscriptionWorkspaceId": "rw_7ccfea89" | ||
| } | ||
| ] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| { | ||
| "id": "3843931114454384640", | ||
| "guid": "89e65110-b580-11f1-8407-405863f40b35", | ||
| "delivered_at": "2026-09-21T05:51:51.082Z", | ||
| "event": "issue_comment", | ||
| "action": "created", | ||
| "status_code": 200, | ||
| "duration": 0.32, | ||
| "comment_id": "5755994597", | ||
| "repository": "AgentWorkforce/cloud" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| # Provider subscription workspace authentication and wake proof | ||
|
|
||
| The resumed worker had real RELAY_WORKSPACE_KEY and RELAY_AGENT_TOKEN values. | ||
| A temporary fetch diagnostic recorded GET https://cast.agentrelay.com/v1/agents | ||
| returning 401, followed by "Workspace key required (rk_live\*...)". Removing only | ||
| RELAY_AGENT_TOKEN made the same request return 200. This was client credential | ||
| selection, not missing worker environment, a masked key, or node configuration. | ||
| No credential values were logged. Temporary diagnostics were removed. | ||
|
|
||
| Integration subscribe/list/unsubscribe (including owned-binding retirement) | ||
| require workspace-owner endpoints. They now use createWorkspaceRelay with the | ||
| same selected workspace as inbound-target and subscription-channel provisioning. | ||
| Explicit --token is rejected with guidance. General agent messaging and other | ||
| agent-scoped operations retain createAgentRelay and its ambient-token rules. | ||
|
|
||
| Validation: 154 focused CLI/auth tests and CLI typecheck pass. Regression tests | ||
| fail before the fix for ambient agent-token setup and explicit-token rejection. | ||
| Running the patched source CLI with the original workspace key AND agent token | ||
| successfully subscribed webhook-subscription-closeout-r2 to | ||
| /github/repos/AgentWorkforce/relayfile/pulls/515/\*\*. The local Relayfile client | ||
| used a 120s request budget for this live proof; the deployed 30s default can | ||
| still time out on overloaded control-plane operations (separate from auth). | ||
|
|
||
| The earlier same-repository Cloud #3896 probe provides the full provider lane: | ||
| GitHub comment 5755994597 -> delivery GUID 89e65110-b580-11f1-8407-405863f40b35 | ||
| -> Relayfile evt_4923952/rev_5368829 -> Relay message 227668215640440832 | ||
| -> this live agent's next input turn. GitHub delivered at 05:51:51.082Z with | ||
| HTTP 200; Relay received at 05:52:12Z (20.918s). Reader confirmation identifies | ||
| this owner at 05:56:16Z. The labeled temporary comment was deleted and its | ||
| GitHub API returned 404. The provider-side IDs are stored as strings in | ||
| subscription-wake-provider.json to preserve integer precision. | ||
|
|
||
| This proves issue_comment.created provider subscription delivery and agent | ||
| input injection. It does not prove production check_run.completed, fork checks, | ||
| or the separate hosted Babysitter flow-listener lane. No merge or deployment | ||
| was performed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.