Repository navigation
fix(connect): update macOS 2026.10.4 before joining - #1884
Conversation
Update an existing macOS app when its live core predates shared Codex daemon support. Keep Linux 2026.10.4 usable and explain session identification failures with a clear update instruction. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (4)
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 1 remain after this review. 📝 WalkthroughWalkthroughThe connect package now applies different minimum probe versions on macOS and Linux. Join, send, status, and leave commands provide Linux update guidance for qualifying probe versions and session errors. ChangesProbe Version Policy
Priority: ➖ Normal Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to No actionable issue remains before merge beyond normal checks. Security Architecture ReviewSecurity architecture risk: 🔵 Low · up to The change tightens macOS compatibility while preserving installation verification and session rejection behavior. Risk is low, with remaining uncertainty around desktop-process cleanup and recovery after interrupted replacement. Retained concerns Security review detailsSecurity Blast Radius
Trust Boundaries and Controls
Resilience and Maintainability Implications
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 15 functions across 3 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches 💡 2📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
🛠️ Fix failing CI checks 💡
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. A rabbit checks the probe at dawn Comment |
There was a problem hiding this comment.
Devin Review found 2 potential issues.
1 flag not posted on this PR by your GitHub settings — view it in Devin Review. (Configure)
There was a problem hiding this comment.
All reported issues were addressed across 4 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Keep the original socket error code in structured mode and explain both the live-session and running-service cases in the Linux 2026.10.4 diagnostic. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Name the macOS install command and preserve the Linux session update guidance for send and leave as well as join and status. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
CI follow-up: the original Flows v2 shard 0 failure in this PR was a transient external Relaycast registration error ( |
Summary
connect installandconnect joinnow use the existing verified app update path when an installed 2026.10.4 core is responsive, and wait for the new core before reporting readiness.joinorstatusgetsnot_a_relay_sessionfrom that version, print one actionable update line instead of telling the user only to run from a live session.Why
On finn-mini, the published
npx -y @agent-relay/connect installreported “Agent Relay probe ready” with an installed 2026.10.4 macOS app. A daemon-backed Codex user would then still receive 403 from session routes because shared app-server identification landed in the released 2026.10.5 desktop core. The published 2026.10.5 DMG fixes the issue, but the hand-over command did not trigger that update.Verification
join,send,status, andleavereturn the one-line guidance in text mode and retain parseablenot_a_relay_sessionJSON with the guidance in its message under--json.joinonce; it updated the app to the published 2026.10.5 release and joined the live Connect asmacprobe-upgrade-proof-2. The app relaunched at 19:57:16.905Z, and the first 2026.10.5 core status was measured 12.326 seconds later at 19:57:29.232Z. The final installed app and launchd core both report 2026.10.5.🤖 Generated with Claude Code