Skip to content

ci: install Rust toolchain in jobs that build the broker on StarSling - #1947

Merged
kjgbot merged 1 commit into
trunkfrom
ci/starsling-rust-toolchain
Oct 9, 2026
Merged

kjgbot merged 1 commit into
trunkfrom
ci/starsling-rust-toolchain

Conversation

@kjgbot

@kjgbot kjgbot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Three jobs on promotion PR #1939 failed right after #1946 moved them to vars.CI_LINUX_RUNNER (starsling-ubuntu-24.04). The failing jobs are test (ubuntu-latest, 22.14.0), Coverage (upload) and Test build-bun.sh (ubuntu-latest). All three failed for the same reason: the Rust compiler preinstalled on the StarSling runners is too old.

Change

Add dtolnay/rust-toolchain@4360b52568e2003a75bf9bc1d59f33a8e3fc893c # stable (the pin other workflows here already use) to the test and coverage jobs in test.yml and the test-build-script job in test-build.yml. These jobs stay on StarSling. I did not touch any runs-on or trunk gate. On macOS the step just confirms that stable is current.

The Codecov upload step has not run on StarSling yet, because the job failed before reaching it. It should be checked on the next #1939 run.

Local checks

  • actionlint .github/workflows/test.yml: clean
  • actionlint .github/workflows/test-build.yml: 9 shellcheck findings, all in steps this PR does not touch. The origin/trunk version of the file has the same 9.
  • python3 -c 'import yaml; ...' on both files: parses

Not in this PR

Flows v2 shard 14 (broker-local-only: "Absent local work must not be dead-lettered") ran on a GitHub-hosted runner, not StarSling, so this change does not affect it. It is tracked separately.

🤖 Generated with Claude Code


Note

Low Risk
CI-only workflow changes with no application or security logic; risk is limited to job runtime and build reliability on custom runners.

Overview
Adds an explicit Rust stable toolchain setup to CI jobs that compile the broker on StarSling Linux runners (vars.CI_LINUX_RUNNER), where preinstalled rustc 1.92 fails on broker code that needs stable Atomic*::try_update.

The new Setup Rust toolchain step (dtolnay/rust-toolchain at the same pinned SHA as rust-ci.yml) runs in test and Coverage (upload) in test.yml, and Test build-bun.sh in test-build.yml, immediately after checkout. macOS matrix legs only verify stable is already present; runner labels and trunk gates are unchanged.

Reviewed by Cursor Bugbot for commit 4faa95a. Bugbot is set up for automated code reviews on this repo. Configure here.

StarSling Linux runners preinstall rustc 1.92.0; GitHub's ubuntu-24.04
image ships 1.99.0. The broker uses atomic try_update (#1907), which 1.92
rejects as unstable (E0658), so test, Coverage (upload) and Test
build-bun.sh failed on trunk -> main #1939 after #1946 routed them to
vars.CI_LINUX_RUNNER. Rust CI jobs already install stable via
dtolnay/rust-toolchain and passed on the same runners.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@kjgbot kjgbot added the mergeable Ready for the merge agent to batch into trunk label Oct 9, 2026
@coderabbitai

coderabbitai Bot commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 67438e92-a3bb-4b52-914b-14d38ba767fe

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

View guided diff | Re-trigger cubic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mergeable Ready for the merge agent to batch into trunk

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant