Repository navigation
ci: install Rust toolchain in jobs that build the broker on StarSling - #1947
Merged
Merged
Conversation
StarSling Linux runners preinstall rustc 1.92.0; GitHub's ubuntu-24.04 image ships 1.99.0. The broker uses atomic try_update (#1907), which 1.92 rejects as unstable (E0658), so test, Coverage (upload) and Test build-bun.sh failed on trunk -> main #1939 after #1946 routed them to vars.CI_LINUX_RUNNER. Rust CI jobs already install stable via dtolnay/rust-toolchain and passed on the same runners. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Oct 9, 2026
This was referenced Oct 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three jobs on promotion PR #1939 failed right after #1946 moved them to
vars.CI_LINUX_RUNNER(starsling-ubuntu-24.04). The failing jobs aretest (ubuntu-latest, 22.14.0),Coverage (upload)andTest build-bun.sh (ubuntu-latest). All three failed for the same reason: the Rust compiler preinstalled on the StarSling runners is too old.ubuntu-24.04image20261004.327ships rustc 1.99.0. I took the 1.92 version from theRust Tests (ubuntu-latest)job log on the same StarSling pool:stable-x86_64-unknown-linux-gnu updated - rustc 1.99.0 ... (from rustc 1.92.0 (ded5c06cf 2025-12-08)).AtomicU*::try_update(crates/broker/src/node_delivery_probe.rs:359, from fix(broker): preserve node tokens across rotation races #1907, already onmain). rustc 1.92 rejects it:mainat5b30a69d7, which already contains fix(broker): preserve node tokens across rotation races #1907 and ran on GitHub runners,test,CoverageandTest build-bun.sh (ubuntu-latest)all passed.dtolnay/rust-toolchain@stableand passed on the same StarSling runners. Installing the toolchain takes about 8s.Change
Add
dtolnay/rust-toolchain@4360b52568e2003a75bf9bc1d59f33a8e3fc893c # stable(the pin other workflows here already use) to thetestandcoveragejobs intest.ymland thetest-build-scriptjob intest-build.yml. These jobs stay on StarSling. I did not touch anyruns-onor trunk gate. On macOS the step just confirms that stable is current.The Codecov upload step has not run on StarSling yet, because the job failed before reaching it. It should be checked on the next #1939 run.
Local checks
actionlint .github/workflows/test.yml: cleanactionlint .github/workflows/test-build.yml: 9 shellcheck findings, all in steps this PR does not touch. Theorigin/trunkversion of the file has the same 9.python3 -c 'import yaml; ...'on both files: parsesNot in this PR
Flows v2 shard 14(broker-local-only: "Absent local work must not be dead-lettered") ran on a GitHub-hosted runner, not StarSling, so this change does not affect it. It is tracked separately.🤖 Generated with Claude Code
Note
Low Risk
CI-only workflow changes with no application or security logic; risk is limited to job runtime and build reliability on custom runners.
Overview
Adds an explicit Rust stable toolchain setup to CI jobs that compile the broker on StarSling Linux runners (
vars.CI_LINUX_RUNNER), where preinstalled rustc 1.92 fails on broker code that needs stableAtomic*::try_update.The new Setup Rust toolchain step (
dtolnay/rust-toolchainat the same pinned SHA asrust-ci.yml) runs intestandCoverage (upload)intest.yml, andTest build-bun.shintest-build.yml, immediately after checkout. macOS matrix legs only verify stable is already present; runner labels and trunk gates are unchanged.Reviewed by Cursor Bugbot for commit 4faa95a. Bugbot is set up for automated code reviews on this repo. Configure here.