Repository navigation
fix(broker): confirm PTY delivery through native acknowledgements #1982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Akarshkushwaha
wants to merge
6
commits into
AgentWorkforce:main
Choose a base branch
from
Akarshkushwaha:fix/1961-native-delivery-acks
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
d4b6b93
fix(broker): confirm PTY deliveries through native MCP acknowledgements
Akarshkushwaha ab780d6
fix(broker): bind native receipts to the recipient identity
Akarshkushwaha 04f436b
test: keep native delivery proof scoped to one case
Akarshkushwaha 11c64b3
fix(broker): preserve native receipt recovery and MCP configuration
Akarshkushwaha d87bfd7
fix(broker): preserve wrap launch options during MCP setup
Akarshkushwaha 63b1034
refactor(broker): remove redundant native receipt plumbing
Akarshkushwaha File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 Other PTY recipients lose confirmation
When a recipient lacks native MCP receipts,
assess_delivery_acceptancediscards even proven process echoes and harness acceptance. Cat and non-Claude/Codex recipients now report successful deliveries as unconfirmed.Learn more
The former acceptance assessor confirms a raw
catprocess echo, a cleared composer, and activity markers. The new wrapper reduces every one of those Accepted outcomes to Inconclusive when no native receipt exists. Only Claude and Codex MCP arguments receive explicit acknowledgement-directory forwarding in configure_harness; a plaincatprocess cannot call an MCP tool. The PTY worker consequently issues terminal unconfirmed instead of the former delivery_verified event.Example: A supported local
catrecipient prints its injected body to the PTY. The formerprocess_echoevidence confirms delivery; the new assessor discards it and marks that delivery unconfirmed.Recommended fix: Restrict receipt-only assessment to recipient configurations that actually support it, and retain process-echo or existing harness acceptance for other supported PTY recipients.
Was this helpful? React with 👍 or 👎 to provide feedback.