-
Notifications
You must be signed in to change notification settings - Fork 1
fix(engine): drain deliveries when agents are released #448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
52 changes: 52 additions & 0 deletions
52
.agentworkforce/trajectories/compacted/compact_whqlsrrkhceb_2026-09-20.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,52 @@ | ||
| { | ||
| "id": "compact_x03t9bwpqklx", | ||
| "version": 1, | ||
| "type": "compacted", | ||
| "compactedAt": "2026-09-20T17:28:10.496Z", | ||
| "sourceTrajectories": [ | ||
| "traj_pcfd4ebl1pam" | ||
| ], | ||
| "dateRange": { | ||
| "start": "2026-09-20T17:13:27.676Z", | ||
| "end": "2026-09-20T17:27:21.837Z" | ||
| }, | ||
| "summary": { | ||
| "totalDecisions": 2, | ||
| "totalEvents": 4, | ||
| "uniqueAgents": [ | ||
| "default" | ||
| ] | ||
| }, | ||
| "decisionGroups": [ | ||
| { | ||
| "category": "other", | ||
| "decisions": [ | ||
| { | ||
| "question": "Require atomic writes for every irreversible release and share node completion implementation", | ||
| "chosen": "Require atomic writes for every irreversible release and share node completion implementation", | ||
| "reasoning": "Sequential fallback can permanently settle deliveries before a later tombstone failure; legacy node completion also committed lifecycle writes separately even on capable adapters.", | ||
| "fromTrajectory": "traj_pcfd4ebl1pam" | ||
| } | ||
| ] | ||
| }, | ||
| { | ||
| "category": "api", | ||
| "decisions": [ | ||
| { | ||
| "question": "Address all three PR threads", | ||
| "chosen": "Address all three PR threads", | ||
| "reasoning": "Devin requires fail-closed local releases; CodeRabbit independently identifies sequential legacy node completion and requests naming both active delivery states in release notes.", | ||
| "fromTrajectory": "traj_pcfd4ebl1pam" | ||
| } | ||
| ] | ||
| } | ||
| ], | ||
| "keyLearnings": [], | ||
| "keyFindings": [ | ||
| "Engine typecheck and lint passed under Node 22.23.2.", | ||
| "Focused release and capacity tests: 101 passed, including 21 new refusal/rollback regressions.", | ||
| "Full engine suite: 1176 tests across 100 files passed with --maxWorkers=2. Initial default-parallel run had one unrelated retention CLI timeout; no timeout or dependency changes were committed." | ||
| ], | ||
| "filesAffected": [], | ||
| "commits": [] | ||
| } |
23 changes: 23 additions & 0 deletions
23
.agentworkforce/trajectories/compacted/compact_whqlsrrkhceb_2026-09-20.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| # Trajectory Compaction: Sep 20, 2026 - Sep 20, 2026 | ||
|
|
||
| ## Summary | ||
| - Sessions: 1 | ||
| - Decisions: 2 | ||
| - Events: 4 | ||
| - Agents: default | ||
| - Files: 0 | ||
| - Commits: 0 | ||
|
|
||
| ## Other | ||
| - Require atomic writes for every irreversible release and share node completion implementation -> Require atomic writes for every irreversible release and share node completion implementation (traj_pcfd4ebl1pam) | ||
|
|
||
| ## Api | ||
| - Address all three PR threads -> Address all three PR threads (traj_pcfd4ebl1pam) | ||
|
|
||
| ## Key Learnings | ||
| - None | ||
|
|
||
| ## Key Findings | ||
| - Engine typecheck and lint passed under Node 22.23.2. | ||
| - Focused release and capacity tests: 101 passed, including 21 new refusal/rollback regressions. | ||
| - Full engine suite: 1176 tests across 100 files passed with `--maxWorkers=2`. Initial default-parallel run had one unrelated retention CLI timeout; no timeout or dependency changes were committed. |
32 changes: 32 additions & 0 deletions
32
.agentworkforce/trajectories/completed/2026-09/traj_2t44mh839vla/summary.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| # Trajectory: Drain workspace delivery capacity when agents are released | ||
|
|
||
| > **Status:** ✅ Completed | ||
| > **Confidence:** 93% | ||
| > **Started:** September 20, 2026 at 09:53 AM | ||
| > **Completed:** September 20, 2026 at 10:00 AM | ||
|
|
||
| --- | ||
|
|
||
| ## Summary | ||
|
|
||
| Dead-lettered active delivery rows during irreversible agent release across direct, local, guarded node, and legacy node lifecycle paths; added release-path and expired-unswept workspace-cap regressions; full engine suite, typecheck, and lint pass. | ||
|
|
||
| **Approach:** Standard approach | ||
|
|
||
| --- | ||
|
|
||
| ## Key Decisions | ||
|
|
||
| ### Fix capacity recovery in the Relaycast engine release lifecycle | ||
| - **Chose:** Fix capacity recovery in the Relaycast engine release lifecycle | ||
| - **Reasoning:** Release stops future fan-out but queued/delivered rows for the tombstoned recipient remain active and continue consuming the workspace cap until TTL. The engine owns both the lifecycle mutation and active-depth accounting, so it can atomically dead-letter those rows on irreversible delete_agent releases across every path. | ||
|
|
||
| --- | ||
|
|
||
| ## Chapters | ||
|
|
||
| ### 1. Work | ||
| *Agent: default* | ||
|
|
||
| - Fix capacity recovery in the Relaycast engine release lifecycle: Fix capacity recovery in the Relaycast engine release lifecycle | ||
| - Release-time settlement now covers direct deletion, local reaping, guarded node completion, and legacy node completion. Full engine suite passed (1,154 tests), and a workspace-cap regression proves expired unswept rows are already excluded from admission. |
73 changes: 73 additions & 0 deletions
73
.agentworkforce/trajectories/completed/2026-09/traj_2t44mh839vla/trajectory.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,73 @@ | ||
| { | ||
| "id": "traj_2t44mh839vla", | ||
| "version": 1, | ||
| "task": { | ||
| "title": "Drain workspace delivery capacity when agents are released" | ||
| }, | ||
| "status": "completed", | ||
| "startedAt": "2026-09-20T16:53:13.768Z", | ||
| "completedAt": "2026-09-20T17:00:33.145Z", | ||
| "agents": [ | ||
| { | ||
| "name": "default", | ||
| "role": "lead", | ||
| "joinedAt": "2026-09-20T16:54:06.278Z" | ||
| } | ||
| ], | ||
| "chapters": [ | ||
| { | ||
| "id": "chap_xydn9gw6mt5u", | ||
| "title": "Work", | ||
| "agentName": "default", | ||
| "startedAt": "2026-09-20T16:54:06.278Z", | ||
| "endedAt": "2026-09-20T17:00:33.145Z", | ||
| "events": [ | ||
| { | ||
| "ts": 1789923246278, | ||
| "type": "decision", | ||
| "content": "Fix capacity recovery in the Relaycast engine release lifecycle: Fix capacity recovery in the Relaycast engine release lifecycle", | ||
| "raw": { | ||
| "question": "Fix capacity recovery in the Relaycast engine release lifecycle", | ||
| "chosen": "Fix capacity recovery in the Relaycast engine release lifecycle", | ||
| "alternatives": [], | ||
| "reasoning": "Release stops future fan-out but queued/delivered rows for the tombstoned recipient remain active and continue consuming the workspace cap until TTL. The engine owns both the lifecycle mutation and active-depth accounting, so it can atomically dead-letter those rows on irreversible delete_agent releases across every path." | ||
| }, | ||
| "significance": "high" | ||
| }, | ||
| { | ||
| "ts": 1789923595490, | ||
| "type": "reflection", | ||
| "content": "Release-time settlement now covers direct deletion, local reaping, guarded node completion, and legacy node completion. Full engine suite passed (1,154 tests), and a workspace-cap regression proves expired unswept rows are already excluded from admission.", | ||
| "raw": { | ||
| "focalPoints": [ | ||
| "release atomicity", | ||
| "capacity accounting", | ||
| "regression coverage" | ||
| ], | ||
| "confidence": 0.9 | ||
| }, | ||
| "significance": "high", | ||
| "tags": [ | ||
| "focal:release atomicity", | ||
| "focal:capacity accounting", | ||
| "focal:regression coverage", | ||
| "confidence:0.9" | ||
| ] | ||
| } | ||
| ] | ||
| } | ||
| ], | ||
| "retrospective": { | ||
| "summary": "Dead-lettered active delivery rows during irreversible agent release across direct, local, guarded node, and legacy node lifecycle paths; added release-path and expired-unswept workspace-cap regressions; full engine suite, typecheck, and lint pass.", | ||
| "approach": "Standard approach", | ||
| "confidence": 0.93 | ||
| }, | ||
| "commits": [], | ||
| "filesChanged": [], | ||
| "projectId": "AgentWorkforce/relaycast", | ||
| "tags": [], | ||
| "_trace": { | ||
| "startRef": "6414a59e619459fa64640937f4c4634c207191f2", | ||
| "endRef": "6414a59e619459fa64640937f4c4634c207191f2" | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
🔎 Supported by static analysis
🏁 Script executed:
Repository: AgentWorkforce/relaycast
Length of output: 5645
Name both delivery states.
Line 706 mentions only queued deliveries, but irreversible release also transitions delivered delivery rows. Update the README so it matches the release contract.
Proposed fix
📝 Committable suggestion
🤖 Prompt for AI Agents