Repository navigation
fix(auth): enforce path ACLs with RelayAuth scopes #423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
khaliqgant
merged 12 commits into
main
from
factory/2174-agentworkforce-relayfile-e6773ae7
Sep 8, 2026
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
2285998
fix(auth): enforce path ACLs with RelayAuth scopes
khaliqgant 99a4e28
Enforce ACL scope shapes
khaliqgant c874e09
fix(auth): preserve exact scopes across current bulk reads
khaliqgant c5c5e06
fix(auth): filter directory ACLs per returned file
khaliqgant a765271
fix(auth): filter ACL-hidden filesystem events
khaliqgant b0df4ad
fix(auth): snapshot ACL on draft deletes; fail closed on unsnapshotte…
khaliqgant 45820e7
fix(auth): route provider-sync deletes through snapshotACLPermissions…
khaliqgant d99d41e
fix: reconcile pathless provider deletes safely
khaliqgant e11a5b7
fix: resolve provider deletes by verified object identity
khaliqgant 9d5f256
fix: make provider projections and reconcile events safe
khaliqgant d64547f
fix: reject ambiguous provider upserts
khaliqgant 0035845
test(acl): prove relative paths cannot bypass denies
khaliqgant File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,80 @@ | ||
| { | ||
| "id": "traj_qtxkeaa5cphq", | ||
| "version": 1, | ||
| "task": { | ||
| "title": "Repair ACL pathless provider deletion reconciliation", | ||
| "source": { | ||
| "system": "plain", | ||
| "id": "Relayfile ACL-423" | ||
| } | ||
| }, | ||
| "status": "completed", | ||
| "startedAt": "2026-09-08T15:41:42.556Z", | ||
| "completedAt": "2026-09-08T15:47:16.049Z", | ||
| "agents": [ | ||
| { | ||
| "name": "default", | ||
| "role": "lead", | ||
| "joinedAt": "2026-09-08T15:41:47.673Z" | ||
| } | ||
| ], | ||
| "chapters": [ | ||
| { | ||
| "id": "chap_bevz9521bn7k", | ||
| "title": "Work", | ||
| "agentName": "default", | ||
| "startedAt": "2026-09-08T15:41:47.673Z", | ||
| "endedAt": "2026-09-08T15:47:16.049Z", | ||
| "events": [ | ||
| { | ||
| "ts": 1788882107674, | ||
| "type": "decision", | ||
| "content": "Use a pathless sync.reconcile control event for unresolved provider deletes: Use a pathless sync.reconcile control event for unresolved provider deletes", | ||
| "raw": { | ||
| "question": "Use a pathless sync.reconcile control event for unresolved provider deletes", | ||
| "chosen": "Use a pathless sync.reconcile control event for unresolved provider deletes", | ||
| "alternatives": [], | ||
| "reasoning": "Never guess or disclose hidden paths; filtered mounts receive an authoritative full reconciliation in the same sync cycle while malformed empty-path file.deleted events remain fail-closed." | ||
| }, | ||
| "significance": "high" | ||
| }, | ||
| { | ||
| "ts": 1788882435983, | ||
| "type": "reflection", | ||
| "content": "Pathless provider deletion now emits only a durable sync.reconcile control when no ACL-backed path can be named; mounts persist the prompt, reconcile authoritatively in-cycle, and filtered consumers receive no path. Focused/full serialized Go and package gates are green; parallel full Go and mountsync race expose inherited test-environment races.", | ||
| "raw": { | ||
| "focalPoints": [ | ||
| "pathless deletion", | ||
| "ACL fail-closed", | ||
| "restart durability", | ||
| "inherited races" | ||
| ], | ||
| "adjustments": "Added durable PendingFullReconcile state and consumer path-filter exceptions", | ||
| "confidence": 0.92 | ||
| }, | ||
| "significance": "high", | ||
| "tags": [ | ||
| "focal:pathless deletion", | ||
| "focal:ACL fail-closed", | ||
| "focal:restart durability", | ||
| "focal:inherited races", | ||
| "confidence:0.92" | ||
| ] | ||
| } | ||
| ] | ||
| } | ||
| ], | ||
| "retrospective": { | ||
| "summary": "Repaired Relayfile ACL pathless provider deletion handling with sync.reconcile control events, durable prompt reconciliation, no-path fail-closed filtering, SDK/file-observer parity, and regression tests.", | ||
| "approach": "Standard approach", | ||
| "confidence": 0.92 | ||
| }, | ||
| "commits": [], | ||
| "filesChanged": [], | ||
| "projectId": "/private/tmp/relayfile-acl423-fix-0908", | ||
| "tags": [], | ||
| "_trace": { | ||
| "startRef": "45820e7a50002a19245f2c5984df996bd650d455", | ||
| "endRef": "45820e7a50002a19245f2c5984df996bd650d455" | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| # Trajectory: Repair ACL pathless provider deletion reconciliation | ||
|
|
||
| > **Status:** ✅ Completed | ||
| > **Task:** Relayfile ACL-423 | ||
| > **Confidence:** 92% | ||
| > **Started:** September 8, 2026 at 05:41 PM | ||
| > **Completed:** September 8, 2026 at 05:47 PM | ||
|
|
||
| --- | ||
|
|
||
| ## Summary | ||
|
|
||
| Repaired Relayfile ACL pathless provider deletion handling with sync.reconcile control events, durable prompt reconciliation, no-path fail-closed filtering, SDK/file-observer parity, and regression tests. | ||
|
|
||
| **Approach:** Standard approach | ||
|
|
||
| --- | ||
|
|
||
| ## Key Decisions | ||
|
|
||
| ### Use a pathless sync.reconcile control event for unresolved provider deletes | ||
| - **Chose:** Use a pathless sync.reconcile control event for unresolved provider deletes | ||
| - **Reasoning:** Never guess or disclose hidden paths; filtered mounts receive an authoritative full reconciliation in the same sync cycle while malformed empty-path file.deleted events remain fail-closed. | ||
|
|
||
| --- | ||
|
|
||
| ## Chapters | ||
|
|
||
| ### 1. Work | ||
| *Agent: default* | ||
|
|
||
| - Use a pathless sync.reconcile control event for unresolved provider deletes: Use a pathless sync.reconcile control event for unresolved provider deletes | ||
| - Pathless provider deletion now emits only a durable sync.reconcile control when no ACL-backed path can be named; mounts persist the prompt, reconcile authoritatively in-cycle, and filtered consumers receive no path. Focused/full serialized Go and package gates are green; parallel full Go and mountsync race expose inherited test-environment races. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.