Repository navigation
desktop 1.1.9, sessions 0.2.8: fleet subscriptions use the installed CLI - #150
Conversation
…_cli Clearing relay_cli for a non-13.x CLI made setting-up-agent-relay-desktop section 6 fall back to npx instead of its own version-specific subscription path for the installed CLI (agentrelay.com#172 review). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Session-Id: 26d00c25-77c9-401f-b9f0-51ce6c9deda6
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (3)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe preflight now runs optional CLI checks only for version 13.x and preserves ChangesAgent relay session setup
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~8 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The preflight keeps the installed CLI available for desktop setup while limiting optional checks to 13.x. No introduced issue was found, so the change appears ready to merge subject to normal checks. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. A rabbit checks the relay's path, Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 04e84a3675
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Shell variables do not survive between tool calls, so relay_cli from section 2 (or the sessions skill) is usually unset by section 6, which then fell back to npx. Section 6 now finds the installed CLI again (section 2's locations plus PATH, never the .deb's /usr/bin/agent-relay launcher) before choosing its version-specific path. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Session-Id: 26d00c25-77c9-401f-b9f0-51ce6c9deda6
|
@codex review |
There was a problem hiding this comment.
All reported issues were addressed
Reply with feedback, questions, or to request a fix.
View guided diff | Re-trigger cubic
|
Codex Review: Didn't find any major issues. Another round soon, please! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
There was a problem hiding this comment.
All reported issues were addressed across 4 files
Reply with feedback, questions, or to request a fix.
View guided diff | Re-trigger cubic
…last Section 2 and section 6 now define the same find_relay_cli: the fixed user-level locations, then mise and nvm installs (find output kept quoted, so spaces survive), then PATH (a mise shim, Homebrew), never the .deb's /usr/bin/agent-relay launcher. Section 2 thus finds the same CLI the sessions skill sees, and section 6 re-finds it in a new shell. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Session-Id: 26d00c25-77c9-401f-b9f0-51ce6c9deda6
|
@codex review |
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Fixes a Devin finding on AgentWorkforce/agentrelay.com#172 at its source.
Sessions 0.2.7 (#147) cleared
relay_cliwhen the installedagent-relaywasn't 13.x.setting-up-agent-relay-desktopsection 6 uses that samerelay_cli, picking a fleet-subscription path by major version: ≥13 directly, <13 withenv -u RELAY_AGENT_TOKEN. The Teams guide runs both skills in one flow, so a 12.x or 14.x install fell through tonpx -y agent-relay@13, which fails without registry access.Now a separate
relay_cli_checksflag gates only the optional read-only 13.x workspace checks, andrelay_cliis left intact.Sessions 0.2.7 → 0.2.8.
🤖 Generated with Claude Code
Note
Low Risk
Documentation-only skill version bumps and shell workflow fixes; no runtime code or credential handling changes.
Overview
Bumps setting-up-agent-relay-desktop to 1.1.9 and setting-up-agent-relay-sessions to 0.2.8, with matching README / prpm.json entries.
Sessions (0.2.8) stops clearing
relay_cliwhen the installed CLI is not 13.x. A newrelay_cli_checksflag limits the 13.x requirement to optional workspace reads (whoami,workspace active, etc.), so the path stays available for the desktop skill’s fleet GitHub subscribe logic.Desktop (1.1.9) centralizes installed CLI discovery in a shared
find_relay_cli()helper (sections 2 and 6, kept in sync), addscommand -vas a fallback, and re-runs discovery in section 6 whenrelay_cliis empty across tool calls so agents don’t fall through tonpx agent-relay@13when a real install exists.Reviewed by Cursor Bugbot for commit bb12fea. Bugbot is set up for automated code reviews on this repo. Configure here.
Agent Relay sessions
claudesession26d00c25· opened viagh pr create· last active 2026-10-08