Repository navigation
fix(persona-kit): consume Linear triggers from adapter catalog - #181
Conversation
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
CodeAnt AI is reviewing your PR. |
|
Warning Review limit reached
More reviews will be available in 57 minutes and 23 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (4)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Reviewed and fixed PR #181 locally. I added missing
I verified the trigger-catalog change against installed Local checks run:
The default parallel workspace build/lint hit local exit |
|
Reviewed PR #181 locally. I confirmed I fixed one blocking test failure outside the PR diff in launch-metadata.test.ts: the sustained ingest failure test now uses mocked interval ticks instead of racing real-time 1 ms timers. Local verification passed: |
|
Reviewed PR #181 locally. I confirmed I fixed one blocking test failure outside the PR diff in launch-metadata.test.ts: the sustained ingest failure test now uses mocked interval ticks instead of racing real-time 1 ms timers. Local verification passed: |
|
✅ pr-reviewer applied fixes — committed and pushed Reviewed PR #181 against the provided diff and traced the Linear trigger catalog impact through No code fixes were needed. The new Local checks run:
The full local check completed successfully. |
Summary
mergeKnownTriggers(...)consumer-side special-case from persona-kit@relayfile/adapter-lineardependency/import; Linear agent webhook event names now come through@relayfile/adapter-core/triggersTriggerNameFor<'linear'>to the sameKnownTriggerName<P>path as every other provider@agentworkforce/persona-kitand@agentworkforce/runtimeto3.0.42for follow-up publishAdapter Source-Of-Truth Assessment
@relayfile/adapter-lineardoes not intentionally keep agent events separate fromsupportedEvents();LinearAdapter.supportedEvents()already returns[...recordEvents, ...LINEAR_AGENT_WEBHOOK_EVENTS].packages/core/src/triggers/catalog.generated.tson current relayfile-adaptersmainalready includesAgentSessionEvent.created,AgentSessionEvent.prompted, and theAppUserNotification.*events underKNOWN_TRIGGER_CATALOG.linear.@relayfile/adapter-core@0.3.31was verified by tarball inspection and already contains those events indist/src/triggers/catalog.generated.{js,d.ts}.node --import tsx packages/core/src/cli.ts triggers checkafter building adapter-core passes, andtriggers generateproduces no adapter diff. So there is no adapter code PR needed for this fast-follow; the violation was only workforce's redundant consumer-side merge.mergeKnownTriggersusage; Linear in workforce was the lone provider-specific consumer merge. Cloud has a separate provider-contract list that imports adapter constants directly, not this persona-kit catalog merge pattern.Verification
corepack pnpm --filter @agentworkforce/persona-kit test-> tests 246, pass 246, fail 0corepack pnpm --filter @agentworkforce/runtime test-> tests 38, pass 38, fail 0node --import tsx packages/core/src/cli.ts triggers check-> exited 0 afternpm run build --workspace @relayfile/adapter-corePublish
blocked-pending-npm-publish: @agentworkforce/persona-kit@3.0.42, @agentworkforce/runtime@3.0.42