Skip to content

chore(persona): drop memory from persona-maker - #212

Merged
khaliqgant merged 1 commit into
mainfrom
chore/persona-maker-drop-memory
Jun 6, 2026
Merged

khaliqgant merged 1 commit into
mainfrom
chore/persona-maker-drop-memory

Conversation

@khaliqgant

Copy link
Copy Markdown
Member

Removes the memory.trajectories opt-in added to the persona-maker built-in in #211.

persona-maker runs on the opencode harness (no MCP injection), and recording isn't wanted on this built-in. The full why+how memory usage remains demonstrated in examples/review-agent (codex) and examples/proactive-issue-resolver (claude).

  • personas/persona-maker.json: removed the memory block
  • regenerated packages/workload-router/src/generated/personas.ts

Verified: persona-maker parses with memory: undefined; workload-router 13 tests + build green. No runtime/persona-kit change.

🤖 Generated with Claude Code

Remove the memory.trajectories opt-in added in #211. persona-maker runs on
opencode (no MCP injection) and recording it isn't wanted on the built-in;
the full why+how usage lives in examples/review-agent + proactive-issue-resolver.
Regenerated workload-router generated/personas.ts.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@gemini-code-assist

Copy link
Copy Markdown

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@codeant-ai

codeant-ai Bot commented Jun 6, 2026

Copy link
Copy Markdown

Your free trial PR review limit of 300 PRs has been reached. Please upgrade your plan to continue using CodeAnt AI.

@coderabbitai

coderabbitai Bot commented Jun 6, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 08ace07d-2517-420d-b0d1-614e8609586a

📥 Commits

Reviewing files that changed from the base of the PR and between 78326b6 and ba076ae.

⛔ Files ignored due to path filters (1)
  • packages/workload-router/src/generated/personas.ts is excluded by !**/generated/**
📒 Files selected for processing (1)
  • personas/persona-maker.json
💤 Files with no reviewable changes (1)
  • personas/persona-maker.json

📝 Walkthrough

Walkthrough

The personas/persona-maker.json configuration file removes its top-level memory block, disabling memory behavior including workspace scope and trajectory tracking. The persona structure now flows directly from harnessSettings to agentsMd without the memory configuration.

Changes

Persona Configuration

Layer / File(s) Summary
Memory configuration removal
personas/persona-maker.json
Removes the top-level memory configuration block (including workspace scope and trajectories setting), so harnessSettings now flows directly to agentsMd.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

A memory once stored in the JSON's keep,
Now fades as we cut it deep,
The config flows clean, from harness to deed,
Trajectories gone—no more do we need! 🐰✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: removing the memory configuration from the persona-maker JSON file.
Description check ✅ Passed The description clearly relates to the changeset, explaining why memory was removed, what was changed, and verification steps performed.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/persona-maker-drop-memory

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Re-trigger cubic

@khaliqgant
khaliqgant merged commit 75e95a8 into main Jun 6, 2026
3 checks passed
@khaliqgant
khaliqgant deleted the chore/persona-maker-drop-memory branch June 6, 2026 19:15
@agent-relay-code

Copy link
Copy Markdown
Contributor

Reviewed PR #212 against the current checkout. I did not find any breakage to fix; the memory removal is consistent between personas/persona-maker.json and the generated catalog, and callers already handle absent memory.

Bot/reviewer comments checked:
Gemini and CodeAnt only posted quota-limit notices, CodeRabbit reported no actionable comments, and cubic reported no issues. No line comments were present.

Local validation passed:
corepack pnpm --filter @agentworkforce/workload-router test
corepack pnpm --filter @agentworkforce/cli test
corepack pnpm run check using a temporary /tmp pnpm shim because global Corepack shim creation was not permitted in this sandbox.

@agent-relay-code

Copy link
Copy Markdown
Contributor

ℹ️ pr-reviewer: review only — no file changes were applied to the PR (nothing to commit after review). The notes below are advisory and were not pushed.

Reviewed PR #212 against the current checkout. I did not find any breakage to fix; the memory removal is consistent between personas/persona-maker.json and the generated catalog, and callers already handle absent memory.

Bot/reviewer comments checked:
Gemini and CodeAnt only posted quota-limit notices, CodeRabbit reported no actionable comments, and cubic reported no issues. No line comments were present.

Local validation passed:
corepack pnpm --filter @agentworkforce/workload-router test
corepack pnpm --filter @agentworkforce/cli test
corepack pnpm run check using a temporary /tmp pnpm shim because global Corepack shim creation was not permitted in this sandbox.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant