Skip to content

fix(runtime): no-trigger personas narrow to AgentEvent (v4.0.0 regression) #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
khaliqgant merged 1 commit into from
Jun 10, 2026
Merged

fix(runtime): no-trigger personas narrow to AgentEvent (v4.0.0 regression) #221

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion packages/runtime/src/define-agent.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,15 @@ type TriggerOnUnion<Tr> = OnLiteralsOf<NonNullable<Tr[keyof Tr]>>;
// for any provider event shape — including 2-segment types like
// `slack.app_mention` that aren't valid `EventType`s (those collapse to `never`
// under `AgentEvent<...>`).
type ProviderEventFor<P extends string, O extends string> = BaseAgentEvent<`${P}.${O}`>;
//
// When `O` is the wide `string` (a persona that declares no concrete trigger
// literals — e.g. team members launched by a dispatcher), fall back to the full
// `AgentEvent` so a `(event: AgentEvent)` handler stays assignable. Without this
// the wide case narrows to `BaseAgentEvent<\`${string}.${string}\`>`, which is
// narrower than `AgentEvent` and rejects an `AgentEvent`-typed handler.
type ProviderEventFor<P extends string, O extends string> = string extends O
? AgentEvent
: BaseAgentEvent<`${P}.${O}`>;

type TriggerProviderEvents<Tr> = {
[P in keyof Tr]: P extends string
Expand Down
Loading