Repository navigation
fix(deps): patch vulnerable transitive deps (shell-quote, protobufjs, hono) and align adapter-core - #224
Conversation
… hono) and align adapter-core Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
💡 Codex ReviewLine 10 in bc9bcab This override applies to both OTLP transformer lineages in the lockfile, including the production path ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
…207.x keeps protobufjs 7.x Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (4)
📝 WalkthroughWalkthroughThis pull request updates dependencies across the workspace. The root ChangesDependency Updates
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Good catch — confirmed and fixed in cd226b2. Verified the defect first: the lockfile's The single un-qualified override is now split into two version-qualified entries: "@opentelemetry/otlp-transformer@<0.217.0>protobufjs": ">=7.5.8 <8.0.0",
"@opentelemetry/otlp-transformer@>=0.217.0>protobufjs": ">=8.2.0",Post-fix lockfile resolutions:
|
Summary
pnpm audit --prodreported 16 vulnerabilities (1 critical, 4 high, 11 moderate), all transitive. After this change: 0 known vulnerabilities.@daytonaio/sdk^0.179.0→^0.185.0inpackages/deployandpackages/daytona-runner(dev + peer). The SDK is the path to the criticalshell-quoteadvisory and the four highprotobufjsadvisories — in the package that executes sandbox commands.pnpm.overridesin the root manifest for what the SDK bump alone didn't fix:shell-quote: >=1.8.4— critical, shell injection via unescaped newlines@opentelemetry/otlp-transformer>protobufjs: >=8.2.0and@grpc/proto-loader>protobufjs: >=7.5.8 <8.0.0— path-specific because the tree has two protobufjs lineages; a flat>=8.2.0would break@grpc/proto-loader(requires^7.5.5)hono: >=4.12.21,qs: >=6.15.2— moderates via@modelcontextprotocol/sdkws: >=8.20.1, plus apnpm.packageExtensionsentry makingwsa direct dep of@daytonaio/sdk— overrides don't apply to peer-only deps (it reaches the tree solely viaisomorphic-ws)@relayfile/adapter-coreat^0.3.31in@agentworkforce/runtimeto match persona-kit (was^0.3.29).Verification
pnpm audit --prod→No known vulnerabilities foundpnpm -r build && pnpm typecheck && pnpm test→ all green (no source changes; manifests + lockfile only)pnpm why @daytonaio/sdk -r→ 0.185.0 resolved everywhere;wsresolves to 8.21.0Maintenance
Each override is tech debt to remove once the owning dependency (
@daytonaio/sdk,@modelcontextprotocol/sdk) ships a release that no longer pulls the vulnerable range. ThepackageExtensionsentry forwsshould be removed together with thewsoverride.🤖 Generated with Claude Code