Repository navigation
fix(persona-kit): bump @relayfile/adapter-core to pick up telegram trigger catalog - #264
Conversation
…igger catalog persona-kit's lintTriggers pins @relayfile/adapter-core via ^0.3.60, which caps resolution below 0.4.0 — so it can never see telegram in KNOWN_TRIGGER_CATALOG even though relayfile-adapters has published it there since 0.4.1 (AgentWorkforce/relayfile-adapters#220). Every persona declaring a telegram trigger (hn-monitor, inbox-buddy, joke-bot, ...) warns "provider \"telegram\" is not in the known-trigger registry" at compile/deploy time as a result. Bump to ^0.5.1 (current latest). Verified against the built package: lintTriggers({ triggers: { telegram: [{ on: 'message' }] } }) now returns [] instead of an unknown_provider warning. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
📝 WalkthroughWalkthrough
ChangesAdapter core upgrade
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related issues
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request updates the @relayfile/adapter-core dependency from ^0.3.60 to ^0.5.1 in packages/persona-kit/package.json along with its lockfile entries. The reviewer recommends also updating this dependency in packages/runtime/package.json to avoid version mismatches, duplicate package installations, and potential runtime issues within the monorepo.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| }, | ||
| "dependencies": { | ||
| "@relayfile/adapter-core": "^0.3.60", | ||
| "@relayfile/adapter-core": "^0.5.1", |
There was a problem hiding this comment.
While updating @relayfile/adapter-core to ^0.5.1 resolves the trigger linting issue in persona-kit, leaving packages/runtime on ^0.3.60 introduces a dependency version mismatch within the monorepo. Since @agentworkforce/runtime depends on @agentworkforce/persona-kit (via workspace:*), having mismatched versions of a core library like @relayfile/adapter-core can lead to duplicate package installations in node_modules and potential runtime issues (such as instanceof check failures or multiple registry instances) if any objects or types are shared between the two packages. To maintain consistency and avoid duplicate dependency resolution, it is highly recommended to also bump @relayfile/adapter-core to ^0.5.1 in packages/runtime/package.json.
Addresses gemini-code-assist review feedback on #264: runtime pinned the same @relayfile/adapter-core dependency at ^0.3.60, one minor behind persona-kit's new ^0.5.1 — bump it too so the monorepo doesn't resolve two different major/minor lines of the same package. runtime only imports the ./vfs-client subpath (unrelated to the trigger-catalog fix), so this is pure version-alignment. Verified safe: typecheck clean, 139/139 tests pass against the bumped dependency. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Addressed the gemini-code-assist feedback in c63b78e: bumped |
Summary
Deploying any persona with a
telegramtrigger (agentsrepo's hn-monitor, inbox-buddy, joke-bot) warns at compile/deploy time:Root cause:
persona-kit'slintTriggerssources its known-trigger list from@relayfile/adapter-core'sKNOWN_TRIGGER_CATALOG, butpersona-kit/package.jsonpins it via^0.3.60— a caret range capped below0.4.0.relayfile-adaptershas actually published telegram's catalog entry since0.4.1(AgentWorkforce/relayfile-adapters#220, confirmed by extracting the real npm tarballs for 0.4.1 through the current 0.5.1 — telegram is in all of them). persona-kit just can never resolve to a version that has it.(I initially misdiagnosed this as telegram never being published at all and filed AgentWorkforce/relayfile-adapters#240 — closed that with a correction once I actually unpacked the published tarballs and found telegram was there all along.)
Change
@relayfile/adapter-corefrom^0.3.60to^0.5.1inpackages/persona-kit/package.json, updatepnpm-lock.yaml.packages/runtime's identical^0.3.60pin alone — runtime only imports@relayfile/adapter-core/vfs-client, unrelated to trigger linting, so out of scope for this fix.Verification
pnpm --filter @agentworkforce/persona-kit installresolves@relayfile/adapter-coreto0.5.1insidepackages/persona-kit/node_modules.npm testinpackages/persona-kit— 286/286 pass.npm run typecheck— clean.Note: merging this doesn't make the warning disappear for users immediately — persona-kit/cli/agentworkforce still need a lockstep release cut before the new
agentworkforceCLI picks it up.🤖 Generated with Claude Code