fix: resolve CI failures and flaky detector tests - #17
Merged
Conversation
- Fix flaky detector test: add filesystem isolation to prevent agent config file pollution between test runs - Fix pnpm version mismatch across all CI workflows (version: 9 -> 9.15.0 to match packageManager field) - Upgrade pnpm/action-setup from v2 to v4 in ci.yml - Upgrade Node.js matrix from [20, 22] to [22, 24] (Node 20 is deprecated on GitHub Actions runners) - Clean up leaked agent config files in beforeEach/afterEach to ensure test isolation across all describe blocks
🔄 Code Analyzer — Review in ProgressThe automated review is currently running. This comment will be replaced with a full report once the analysis completes. ⏳ Status: Running security, standards, and code-quality checks... Last updated: 2026-07-28T05:39:34.689Z |
|
The review encountered issues:
Please check the workflow logs for details. 🤖 Generated by Code Analyzer |
🏎️ Benchmark Results
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes all CI failures on the main branch and makes the detector tests robust against environment pollution.
Root causes fixed
Flaky detector tests: Test environment pollution from agent config files in $HOME caused non-deterministic test failures. Added filesystem isolation in
beforeEach/afterEachto clean up leaked config files.pnpm version conflict: All CI workflows specified
version: 9whilepackage.jsondeclarespackageManager: pnpm@9.15.0. The pnpm/action-setup v4 detects this mismatch and fails. Fixed by specifying exact version9.15.0.Node.js 20 deprecation: GitHub Actions deprecated Node 20. Updated test matrix from
[20, 22]to[22, 24].pnpm/action-setup v2 → v4: Upgraded in ci.yml for consistency with other workflows.
Verification