fix: enforce coverage thresholds + add node/web integration tests - #23
Merged
Conversation
- Remove all continue-on-error from ci.yml, release.yml - Add vitest coverage thresholds (>=95% lines/functions/statements, >=90% branches) - Add ci-coverage-check.js to integration-test job - Add 13 unit tests to close coverage gaps (batch-processor, pooling, pre-tokenizer, vocab-loader, tokenizer) - Fix release.yml benchmark output paths - Exclude docs/ from prettier
Lambertyan
force-pushed
the
fix-coverage-reports
branch
from
July 3, 2026 11:11
aeb916d to
dac1631
Compare
…th real ONNX model - Add 7 tests for NodeEmbedder (create, embed, embedBatch, dispose, modelInfo) - Add 5 tests for WebEmbedder (embed, embedBatch, dispose, modelInfo) via WASM - Add 5 tests for ort-backend (createTensor, dispose) - Extend vitest.config.ts coverage include to embed-code-web/src - Exclude embedder-interface.ts and ort-backend-interface.ts from coverage - Add file:// protocol support in WebEmbedder.create() for Node.js testing - Extend descriptor tests to cover weights field and missing weights/onnx branches - Overall coverage: Lines 97.11%, Statements 96.52%, Functions 98.48%, Branches 93.33%
Lambertyan
force-pushed
the
fix-coverage-reports
branch
from
July 3, 2026 11:12
dac1631 to
5add8d1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary