Skip to content

fix: support Qt 6.4 DOM parsing in CI#6

Merged
AhmedAredah merged 2 commits into
masterfrom
chore/ci-advisory-cleanup
May 6, 2026
Merged

fix: support Qt 6.4 DOM parsing in CI#6
AhmedAredah merged 2 commits into
masterfrom
chore/ci-advisory-cleanup

Conversation

@AhmedAredah

@AhmedAredah AhmedAredah commented May 6, 2026

Copy link
Copy Markdown
Owner

Summary:

  • Keep clang-format advisory without a failed-step annotation.
  • Keep CargoNetSim configure/build advisory without failed-step annotations.
  • Fix RabbitMQ XML parsing to support Qt 6.4.2, where QDomDocument::setContent() returns bool instead of ParseResult.

Context:

  • PR chore: add CI scaffold and CHANGELOG #5 is already merged and its jobs are green, but GitHub still shows red annotations from advisory steps that intentionally exited nonzero.
  • CI uses Ubuntu 24.04 apt Qt 6.4.2; local builds may use newer Qt, such as 6.10.1, where setContent() returns QDomDocument::ParseResult.
  • This keeps the scaffold non-blocking while making the Actions UI cleaner and removes the source compile error on Qt 6.4.2.

Test plan:

  • GitHub Actions run for this PR shows Lint and Build Linux as successful.
  • clang-format drift is reported as a warning, not a failed step.
  • CargoNetSim builds past SimulationClientBase.cpp on Qt 6.4.2.

@AhmedAredah AhmedAredah changed the title chore: clean up advisory CI warnings fix: support Qt 6.4 DOM parsing in CI May 6, 2026
@AhmedAredah AhmedAredah merged commit 2e41316 into master May 6, 2026
2 checks passed
@AhmedAredah AhmedAredah deleted the chore/ci-advisory-cleanup branch May 6, 2026 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant