Skip to content

Remove obsolete GUI loop facade - #22

Open
thenderson21 wants to merge 2 commits into
developfrom
fix/remove-obsolete-gui-loop
Open

Remove obsolete GUI loop facade#22
thenderson21 wants to merge 2 commits into
developfrom
fix/remove-obsolete-gui-loop

Conversation

@thenderson21

Copy link
Copy Markdown
Contributor

Summary

  • remove the unused pre-release guiRun/guiLoop facade
  • eliminate unresolved appRender/appUpdate references from the public AiVectra library
  • keep application event-loop ownership in application modules

Validation

  • ./scripts/test-all.sh
  • git diff --check

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: cc0987c6b1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/AiVectra/src/lib.aos
@@ -302,7 +251,5 @@ Program {
Export(name=debugModeLive)
Export(name=guiModeFromArgs)
Export(name=guiBuild)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Update the runtime contract when removing guiRun

Any app authored against the repository's current contract now fails to resolve guiRun: test-fixtures/HelloWorld/AGENTS.md:6 explicitly requires guiBuild and guiRun, while SPEC/APP_RUNTIME.md:5-18 and SPEC/APP_RUNTIME.md:112-121 still state that AiVectra supplies the GUI adapter and samples consume its public runtime API. Because this hunk removes the only definition and export without updating those contracts or providing the promised application-owned replacement, canonical consumers have no implementable lifecycle; update the SPEC and fixture guidance/sample to the new path in the same change.

AGENTS.md reference: AGENTS.md:L114-L119

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant