Don't crash on /read-only when a pattern can't be globbed#5346
Open
ikatyal2110 wants to merge 1 commit into
Open
Don't crash on /read-only when a pattern can't be globbed#5346ikatyal2110 wants to merge 1 commit into
ikatyal2110 wants to merge 1 commit into
Conversation
Path.glob() raises NotImplementedError for non-relative patterns (e.g. a Windows drive-relative path), which propagated out of cmd_read_only and crashed aider entirely. Wrap the glob calls and report the bad pattern instead of letting it take down the app. Fixes Aider-AI#5311
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows, /read-only with a drive-relative pattern crashes aider entirely — Path.glob() raises NotImplementedError ('Non-relative patterns are unsupported') and it wasn't caught. Wrapped the glob calls in cmd_read_only so a pattern that can't be globbed is reported as an error instead of taking down the whole app. Added a test. Fixes #5311