fix: keep run and test commands in the requested cwd#5348
Open
rodboev wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/runand/testalready pass aider's selected cwd intorun_cmd(), but the pexpect path starts the shell with-i -c. Interactive startup files run first, so a.bashrcwithcd ...can move the command before it executes.This keeps the existing pexpect streaming path, but runs shell commands with
-cinstead of-i -cso the requested cwd remains authoritative.Closes #4270
Issue #4270's
.bashrc cdreproduction shaped the regression test for this fix.Tests:
rtk python -m pytest tests/basic/test_run_cmd.py -vrtk pre-commit run --all-filesLatest run:
rtk python -m pytest tests/basic/test_run_cmd.py -v: passedrtk pre-commit run --all-files: passed