fix: make drop match only the named path#5350
Open
rodboev wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/dropwas using substring matching for non-glob paths. That made a command like/drop api\chat\route.tsremove bothapi\chat\route.tsandapp\api\chat\route.tswhen both files were in chat.This keeps bare
/dropand explicit glob behavior intact, but makes non-glob editable and read-only drops use exact path identity instead of substring containment.Closes #4176
The duplicate-path reproduction from
emincangencer's comment shaped the editable and read-only regression tests.Validation:
rtk python -m pytest tests/basic/test_commands.py -k cmd_drop -v6 passed, 67 deselected(run withTEMP/TMP/TMPDIR=D:\Repos\tmp)rtk python -m pytest tests/basic/test_commands.py::TestCommands::test_cmd_add_drop_directory tests/basic/test_commands.py::TestCommands::test_cmd_read_only_with_square_brackets -v2 passedrtk pre-commit run --all-filesisort,black,flake8, andcodespellall passed