fix(models): honor custom_openai metadata during environment validation#5352
Open
rodboev wants to merge 2 commits into
Open
fix(models): honor custom_openai metadata during environment validation#5352rodboev wants to merge 2 commits into
rodboev wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current
Model.validate_environment()still lets metadata-backedcustom_openai/<model>names fall through LiteLLM environment validation, so aider can report a missingOPENAI_API_KEYeven when the model metadata already declareslitellm_provider: custom_openai.This keeps the fix in
aider/models.py: metadata-declaredcustom_openaimodels stop forcing aider-side API-key validation, while every non-custom provider stays on the existing fast path, LiteLLM validation, AWS_PROFILE adjustment, and provider-specific checks. A prefix-onlycustom_openai/name still does not bypass validation.Closes #4955
Tests:
python -m pytest tests/basic/test_models.py -k "custom_openai_metadata_bypasses_litellm_validation or non_custom_metadata_still_uses_litellm_validation" -vpython -m pytest tests/basic/test_aws_credentials.py -vpre-commit run --all-files