Repository navigation
feat: add zaimanhua template - #842
Conversation
5b4ee96 to
bd4742e
Compare
| .collect(); | ||
| let page_size = entries.len() as i32; | ||
| MangaPageResult { | ||
| has_next_page: page_size > 0 && self.total > page * page_size, |
There was a problem hiding this comment.
is page_size reliable here? I imagine that the final page has less than the usual number of entries for a page size, so it will always fetch another page despite one not existing. does the api data provide a consistent page size?
There was a problem hiding this comment.
is
page_sizereliable here? I imagine that the final page has less than the usual number of entries for a page size, so it will always fetch another page despite one not existing. does the api data provide a consistent page size?
I re-checked the requests and noticed that the mobile site always seems to pass a fixed size of 20, so I updated it to use that.
| "type": "switch", | ||
| "key": "chapterComments", | ||
| "title": "章末吐槽", | ||
| "requiresFalse": "contentType == novel" |
There was a problem hiding this comment.
does this work? I didn't know you could do this.
There was a problem hiding this comment.
does this work? I didn't know you could do this.
do you mean requiresFalse: "contentType == novel"?
I confirmed it works, though on Aidoku versions below 0.9 it doesn't disable the toggle... also, the site seems accessible outside mainland China now if you'd like to take a look.
|
After selecting one type, the other type's content will become unavailable. You'll need to provide a mixed category to browse and search all types of content. |
I’m not really sure how to do this cleanly, since the comic and novel APIs are separate, and they don't completely mirror each other. I was especially unsure how to handle the filters in a Mixed type. |
Then I think it's better to submit fiction content as a separate source e.g. zh.zainovel (再小说) rather than providing content in the same source-switching results in users having to choose between two types of content to discard the other. Just like zh.bilimanga and zh.bilinovel already in this repository. |
kkantan
left a comment
kkantan
left a comment
There was a problem hiding this comment.
as dyphire is saying, I do believe that separating this into two different sources, using a template, may be better for users. that, or making the novel content type a search filter instead of a source setting, so that switching between the content types is easier.
| pub authors: Option<String>, | ||
| pub struct ChapterPages { | ||
| #[serde(default)] | ||
| pub page_url: Vec<String>, |
There was a problem hiding this comment.
there was a page_url_hd field before that was preferred over page_url if it existed. is that gone now?
There was a problem hiding this comment.
there was a
page_url_hdfield before that was preferred overpage_urlif it existed. is that gone now?
there didn't seem to be any difference between the two. if differences show up later, I'll bring it back.
forgot that both can coexist, so I'll bring page_url_hd back and fall back to page_url.
- extract a shared template for comics and light novels - add zh.zaimanhuanovel for the site's light novels - parse chapter and volume numbers from comic titles - add an optional end-of-chapter comments page for comics - align behavior with the official app - remove obsolete proxy settings
|
I let a coding agent handle extracting the shared template, and it seems better than I expected... (?) as for the naming, Zaimanhua is the site's main platform name, and the novels are just part of it, so naming it 再漫画轻小说 ( |
Aiko3993
changed the title
kkantan
left a comment
kkantan
left a comment
There was a problem hiding this comment.
this looks fine to me, but the site doesn't appear to load for me outside of china so I can't test it.
that's weird, testing on globalping.io shows it seems to be accessible. I also accessed the source using a proxy set up on a US VPS. 
|
Uh oh!
There was an error while loading. Please reload this page.