add uvicorn context-creation support when run with gUnicorn #576
Conversation
intercepts status codes
This reverts commit 7f97945.
bitterpanda63
changed the title
| @@ -0,0 +1,53 @@ | |||
| # Django ASGI | |||
There was a problem hiding this comment.
Can we document the caveats? of the limited support? e.g. https://github.com/AikidoSec/firewall-node/blob/main/docs/next.md#caveats
There was a problem hiding this comment.
there are no caveats, the limited support is about with which frameworks it works? not sure how I am supposed to clarify that further, is already in bold under ## Support (as in limited support)
| await self.client_app(receive, send) | ||
| else: | ||
| # client_app = coroutine application(scope, receive, send) | ||
| await self.client_app(scope, receive, send) |
There was a problem hiding this comment.
wdym, returning the value? not done for ASGI apps
bitterpanda63
force-pushed
the
add-django-asgi-support
branch
from
57eed8f to
af0b50c
Compare
![aikido-pr-checks[bot]](https://avatars.githubusercontent.com/in/898896?s=60&v=4){kind=small}
|
|
||
| @on_import("psycopg.cursor_async", "psycopg", version_requirement="3.1.0") | ||
| def patch_async(m): | ||
| """ |
There was a problem hiding this comment.
Docstring in patch_async only restates that it patches psycopg.cursor_async. Replace with the rationale for the async-specific patch or remove the redundant comment.
Details
✨ AI Reasoning
An added docstring for the newly introduced async patch function merely restates that it patches the psycopg.cursor_async module and that it's similar to the normal patch. This repeats what the code (registering AsyncCursor.copy/execute/executemany) already shows and doesn't explain why the separate async patch is needed or any design rationale. A 'why' comment or removal would be more valuable.
🔧 How do I fix it?
Write comments that explain the purpose, reasoning, or business logic behind the code using words like 'because', 'so that', or 'in order to'.
Reply @AikidoSec feedback: [FEEDBACK] to get better review comments in the future.
Reply @AikidoSec ignore: [REASON] to ignore this issue.
More info
Summary by Aikido
🚀 New Features
⚡ Enhancements
🔧 Refactors
More info