senders: fix blocking logs on missing 'timestamp' field in rsyslog and ES/OS senders#186
Merged
ngilles-aiven merged 1 commit intomasterfrom Mar 10, 2026
Conversation
…d ES/OS senders Messages can lack a 'timestamp' field when a field filter whitelist strips it, or when `_truncate_long_message` replaces an oversized entry with an error stub. The rsyslog and elasticsearch/opensearch senders accessed `message["timestamp"]` with a hard dict lookup, causing a KeyError that was caught by the broad exception handler and retried indefinitely — blocking log delivery for the affected integration. Fix by using a fallback to the current UTC time in both senders, and by preserving the timestamp in `_truncate_long_message` so truncated entries remain well-formed for downstream senders.
dogukancagatay
force-pushed
the
dogukancagatay/fix-blocking-logs-on-missing-timestamp-fields
branch
from
6822885 to
19b111b
Compare
ngilles-aiven
approved these changes
Mar 10, 2026
ngilles-aiven
deleted the
dogukancagatay/fix-blocking-logs-on-missing-timestamp-fields
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Messages can lack a 'timestamp' field when a field filter whitelist
strips it, or when
_truncate_long_messagereplaces an oversized entrywith an error stub. The rsyslog and elasticsearch/opensearch senders
accessed
message["timestamp"]with a hard dict lookup, causing aKeyError that was caught by the broad exception handler and retried
indefinitely — blocking log delivery for the affected integration.
Fix by using a fallback to the current UTC time in both senders,
and by preserving the timestamp in
_truncate_long_messageso truncated entries remain well-formed for downstream senders.