Skip to content

rsyslog: use ssl.create_default_context for secure TLS #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dogukancagatay wants to merge 1 commit into from
Closed

rsyslog: use ssl.create_default_context for secure TLS #189

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions journalpump/rsyslog.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,11 +108,8 @@
if protocol is None:
protocol = "PLAINTEXT"
if cacerts is not None or protocol == "SSL":
self.ssl_context = ssl.SSLContext(ssl.PROTOCOL_TLS)
self.ssl_context = ssl.create_default_context(cafile=cacerts)
self.ssl_context.minimum_version = ssl.TLSVersion.TLSv1_2
self.ssl_context.verify_mode = ssl.CERT_REQUIRED
if cacerts:
self.ssl_context.load_verify_locations(cacerts)
if certfile:
self.ssl_context.load_cert_chain(certfile, keyfile)

Expand All @@ -131,7 +128,7 @@
self.socket = self.ssl_context.wrap_socket(self.socket, server_hostname=self.server)
self.socket.connect(sock_addr)
return
except Exception as ex: # pylint: disable=broad-except

Check failure

Code scanning / CodeQL

Use of insecure SSL/TLS version High

Insecure SSL/TLS protocol version TLSv1 allowed by
call to ssl.SSLContext
Loading
.
Insecure SSL/TLS protocol version TLSv1_1 allowed by
call to ssl.SSLContext
Loading
.
if self.socket is not None:
self.socket.close()
last_connection_error = ex
Expand Down