rsyslog: use ssl.create_default_context for secure TLS#192
Open
dogukancagatay wants to merge 1 commit intomasterfrom
Open
rsyslog: use ssl.create_default_context for secure TLS#192dogukancagatay wants to merge 1 commit intomasterfrom
dogukancagatay wants to merge 1 commit intomasterfrom
Conversation
Replace manual ssl.SSLContext(ssl.PROTOCOL_TLS_CLIENT) with ssl.create_default_context(), which is the Python-recommended factory for creating secure TLS contexts. This resolves the CodeQL py/insecure-protocol alert (CWE-327) as CodeQL recognizes create_default_context as inherently safe. This resolves the CodeQL alert for CWE-327 (use of a broken or weak cryptographic algorithm).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace manual ssl.SSLContext(ssl.PROTOCOL_TLS_CLIENT) with
ssl.create_default_context(), which is the Python-recommended
factory for creating secure TLS contexts. This resolves the
CodeQL py/insecure-protocol alert (CWE-327) as CodeQL recognizes
create_default_context as inherently safe.
This resolves the CodeQL alert for CWE-327 (use of a broken or
weak cryptographic algorithm).