Skip to content

Improve HTTPS support for client development#23

Merged
jimenezz22 merged 1 commit into
AkatsukiLabs:mainfrom
kronosapiens:main
Jun 17, 2025
Merged

Improve HTTPS support for client development#23
jimenezz22 merged 1 commit into
AkatsukiLabs:mainfrom
kronosapiens:main

Conversation

@kronosapiens
Copy link
Copy Markdown
Contributor

Controller requires HTTPS to connect to the client. This PR makes HTTPS the default behavior for local development.

  • Create the local certificate with npm run mkcert
  • Add the certificate to the Vite config

Comment thread client/vite.config.ts
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kronosapiens I understand your point about adding the HTTPS certificate configurations to localhost. The problem is that we have a deployment in Vercel, and it would crash if these certificates were allowed. I'm going to merge your PR and configure this VITE file to work dynamically based on the environment

@jimenezz22 jimenezz22 merged commit 6c76c78 into AkatsukiLabs:main Jun 17, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants