fix(deps): bump go to 1.26.4 and go-git to v5.19.1 [security]#32
Open
Tongcaiyun wants to merge 1 commit into
Open
fix(deps): bump go to 1.26.4 and go-git to v5.19.1 [security]#32Tongcaiyun wants to merge 1 commit into
Tongcaiyun wants to merge 1 commit into
Conversation
The gomplate binary is baked into the GitLab CNG gitlab-base image (via gitlab-binary), so its compiled stdlib and go-git versions surface in image scans for gitlab-base/certificates/gitaly/gitlab-shell/cfssl. At v4.3.4-alauda-31 this module is go 1.26.3 + go-git v5.19.0, which keeps reporting: - stdlib: CVE-2026-27145, CVE-2026-42504, CVE-2026-42507 (fixed in 1.26.4) - go-git: CVE-2026-45570/45571, GHSA-w5pp-99ch-qj29 (fixed in v5.19.1) Bump the go directive to 1.26.4 (forces the build toolchain up under GOTOOLCHAIN=auto) and go-git to v5.19.1. go mod tidy + go mod verify pass. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The gomplate binary built from this fork is baked into the GitLab CNG
gitlab-baseimage (viagitlab-binary). Its compiledstdlibandgo-gitversions therefore surface in image vulnerability scans ofgitlab-base,certificates,gitaly,gitlab-shell,cfssl-self-sign.At the current latest release
v4.3.4-alauda-31, this module isgo 1.26.3+go-git/go-git v5.19.0, which keeps the GitLab bundle scan reporting (PkgPath=null, i.e. compiled into the gomplate binary):These are the only findings left unaddressed after the gitlab-chart vuln fix; they cannot be fixed chart-side because they live in this prebuilt binary.
What
godirective1.26.3→1.26.4(forces the build toolchain to >= 1.26.4 underGOTOOLCHAIN=auto, clearing the stdlib CVEs).go-git/go-git/v5v5.19.0→v5.19.1(clears the go-git CVEs).go-billyis already at the fixedv5.9.0.go mod tidyandgo mod verifypass locally; diff is go.mod + go.sum only.Follow-up (not in this PR)
After this merges and a new release (e.g.
v4.3.4-alauda-32) is cut,gitlab-chartmust bumpGOMPLATE_VERSIONinmodules/dependencies/Containerfile.binaryto that tag and rebuild so the new binary lands ingitlab-base.🤖 Generated with Claude Code