Skip to content

chore: add .catalog registration for harbor-cli#15

Merged
chengjingtao merged 1 commit into
alauda-v0.0.18from
chore-add-catalog
Apr 29, 2026
Merged

chore: add .catalog registration for harbor-cli#15
chengjingtao merged 1 commit into
alauda-v0.0.18from
chore-add-catalog

Conversation

@chengjingtao

Copy link
Copy Markdown

Summary

  • Add .catalog/harbor-cli.yaml following the Confluence catalog collection standard
  • Registers harbor-cli as a tool component (CLI, no container images)
  • Includes open-source component metadata (upstream: goharbor/harbor-cli, Apache-2.0)

Test plan

  • Verify YAML passes Backstage catalog validation

🤖 Generated with Claude Code

Add Backstage catalog YAML following the Confluence catalog collection
standard. Registers harbor-cli as a tool component with open-source
metadata (upstream: goharbor/harbor-cli, Apache-2.0). No container
images — CLI tool only.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@chengjingtao chengjingtao merged commit 2aeaf4d into alauda-v0.0.18 Apr 29, 2026
3 of 4 checks passed
@chengjingtao chengjingtao deleted the chore-add-catalog branch April 29, 2026 09:08
Comment thread .catalog/harbor-cli.yaml
acp.cpaas.io/open-source-component-license: Apache-2.0
# 开源组件的license地址,格式 ${url}/${project}/${repo}/${license-path}
acp.cpaas.io/open-source-component-license_url: https://github.com/goharbor/harbor-cli/blob/main/LICENSE
acp.cpaas.io/owner: jtcheng@alauda.io

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Critical (bug/format): Incorrect value format. The spec.system field should contain just the system name (devops-tools), not the prefixed format (system:devops-tools). According to Backstage spec, spec.system is an optional field that references the system name directly. Using the system: prefix may cause validation failures.

Suggested change
acp.cpaas.io/owner: jtcheng@alauda.io
system: devops-tools

Comment thread .catalog/harbor-cli.yaml

# 组件属性,区别是否部署时必带的核心组件,可选值为 core 和 plugin。
acp.cpaas.io/functional-attributes: plugin

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion (refactor/consistency): Consider aligning spec.owner (devops) with metadata.annotations.acp.cpaas.io/owner (jtcheng@alauda.io) for consistency in ownership representation across the catalog entity.

@alaudabot

Copy link
Copy Markdown

🤖 AI Code Review

Property Value
Model opencode/minimax-m2.5-free
Style strict
Issues Found 1
Config Source centralized
Profile ❌ Not Found
Personalized Prompt ❌ No
Prompt Path .github/review/profiles/alaudadevops/harbor-cli/pr-review.md
Alauda Skills ✅ base-acp-operator-list, base-acp-operator-release, base-authoring, base-m365, base-ocp-operator-list, base-skill-setup, builders-component-knowledge, builders-confluence, builders-jira, builders-prd-to-testcase, builders-publish-errata, builders-roadmap-studio, builders-story-split, cross-repo-add-mirror, cross-repo-publish, devops-autodns, devops-candidate-version-supervisor, devops-connectors-acceptance-test, devops-connectors-explore, devops-connectors-poc-case, devops-connectors-review, devops-connectors-unit-test, devops-connectors-upgrade-test, devops-connectors-write-user-docs, devops-fix-go-vulns, devops-fork-alauda-binary-release, devops-gen-advanced-form-descriptors, devops-knowledge-adoption, devops-refresh-containerfile-digests, devops-refresh-containerfile-tags, devops-replace-strings, devops-scan-docker-keywords, devops-sync-alauda-github-releases, devops-tekton-dynamic-form-optimizer, devops-tekton-operator-task-e2e, devops-tekton-task-generator, devops-tekton-task-overview-template, devops-tekton-task-version-upgrade, devops-tekton-upgrade-notes, devops-tool-report-troubleshoot, devops-ui-e2e-code-audit, devops-ui-e2e-fix-base-on-report, devops-ui-e2e-regression-and-fix, devops-ui-generate-e2e-from-feature, devops-ui-pre-setup, devops-upgrade-go, devops-upstream-backport-cve, devops-upstream-upgrade
Reviewed at 2026-04-29 09:14:15 UTC

Summary

This PR adds a Backstage catalog registration file (.catalog/harbor-cli.yaml) for harbor-cli as a tool component. The file follows the Backstage Component entity format with proper metadata annotations for the Alauda ACP platform. However, there's a format issue with the system field in the spec section that should be corrected.

Review Statistics

Category Count
Critical Issues 1
Warnings 0
Suggestions 1
Files Reviewed 1

Critical Issues

Issues that MUST be addressed before merging (security, bugs, breaking changes)

  • [.catalog/harbor-cli.yaml:19] spec/system: Incorrect value format. The system field should contain just the system name (devops-tools), not the prefixed format (system:devops-tools). According to Backstage spec, spec.system is an optional field that references the system name directly. Using the system: prefix may cause validation failures in Backstage.

Warnings

Issues that SHOULD be addressed but are not blocking

(None)

Suggestions

Recommendations for improvement (nice to have)

  • [.catalog/harbor-cli.yaml:23] Consider aligning spec.owner (devops) with metadata.annotations.acp.cpaas.io/owner (jtcheng@alauda.io) for consistency, or verify this is intentional (e.g., spec.owner is the team/group while annotation is the technical lead).

Positive Feedback

The catalog file is well-structured and follows the Backstage Component entity format correctly. The annotations include proper ACP-specific metadata for the Alauda platform (open-source component info, license, owner, functional attributes). The file is properly placed in the .catalog/ directory as per the Confluence catalog collection standard.



ℹ️ About this review

This review was automatically generated using the run-actions workflow.

  • Shared prompt: .github/prompts/code-review.md
  • Config source: centralized
  • Profile path: Not Found
  • Profile ref: ebb6c9593926ecbd0b2b1d3ebde0c09c862ff8bf
  • No repository-specific prompt configured
  • Alauda skills: base-acp-operator-list, base-acp-operator-release, base-authoring, base-m365, base-ocp-operator-list, base-skill-setup, builders-component-knowledge, builders-confluence, builders-jira, builders-prd-to-testcase, builders-publish-errata, builders-roadmap-studio, builders-story-split, cross-repo-add-mirror, cross-repo-publish, devops-autodns, devops-candidate-version-supervisor, devops-connectors-acceptance-test, devops-connectors-explore, devops-connectors-poc-case, devops-connectors-review, devops-connectors-unit-test, devops-connectors-upgrade-test, devops-connectors-write-user-docs, devops-fix-go-vulns, devops-fork-alauda-binary-release, devops-gen-advanced-form-descriptors, devops-knowledge-adoption, devops-refresh-containerfile-digests, devops-refresh-containerfile-tags, devops-replace-strings, devops-scan-docker-keywords, devops-sync-alauda-github-releases, devops-tekton-dynamic-form-optimizer, devops-tekton-operator-task-e2e, devops-tekton-task-generator, devops-tekton-task-overview-template, devops-tekton-task-version-upgrade, devops-tekton-upgrade-notes, devops-tool-report-troubleshoot, devops-ui-e2e-code-audit, devops-ui-e2e-fix-base-on-report, devops-ui-e2e-regression-and-fix, devops-ui-generate-e2e-from-feature, devops-ui-pre-setup, devops-upgrade-go, devops-upstream-backport-cve, devops-upstream-upgrade

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants