Skip to content

ci: add nfpm and apk steps to alauda release workflow#4

Merged
chengjingtao merged 1 commit into
alauda-v0.0.18from
fix/release-missing-steps
Apr 19, 2026
Merged

ci: add nfpm and apk steps to alauda release workflow#4
chengjingtao merged 1 commit into
alauda-v0.0.18from
fix/release-missing-steps

Conversation

@chengjingtao

Copy link
Copy Markdown

Summary

Fix alauda release workflow failure caused by missing deb/, rpm/, apk/ directories.

  • Checksum step calls DistBinaries() which runs ls on archive/, deb/, rpm/, apk/ dirs
  • Without nfpm-build and apk steps, those directories don't exist → ls deb: No such file or directory
  • Add the missing build steps to match the upstream default.yaml pipeline

Failed run: https://github.com/AlaudaDevops/harbor-cli/actions/runs/24543124484

Test plan

  • Merge triggers auto-tag → release workflow succeeds with all steps

🤖 Generated with Claude Code

The checksum step calls DistBinaries() which expects deb/, rpm/, apk/
directories to exist. Without nfpm-build and apk steps these directories
are missing, causing `ls deb: No such file or directory` failure.

Add the missing build steps to match the upstream default.yaml pipeline.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@alaudabot

Copy link
Copy Markdown

🤖 AI Code Review

Property Value
Model opencode/minimax-m2.5-free
Style strict
Issues Found 0
Config Source centralized
Profile ❌ Not Found
Personalized Prompt ❌ No
Prompt Path .github/review/profiles/alaudadevops/harbor-cli/pr-review.md
Alauda Skills ✅ base-sample-email-draft, base-skill-setup, builders-component-knowledge, builders-confluence, builders-jira, builders-sample-code-review, connectors-explore, connectors-poc-case, connectors-review, connectors-unit-test, connectors-write-user-docs, devops-autodns, devops-bulk-string-replace, devops-candidate-version-supervisor, devops-docker-keyword-analysis, devops-gen-advanced-form-descriptors, devops-go-vuln-fix, devops-knowledge-adoption, devops-refresh-alauda-tags, devops-sync-alauda-github-releases, devops-tekton-dynamic-form-optimizer, devops-tekton-operator-task-e2e, devops-tekton-task-generator, devops-tekton-task-overview-template, devops-tekton-task-version-upgrade, devops-tekton-upgrade-notes, devops-ui-e2e-code-audit, devops-ui-e2e-fix-base-on-report, devops-ui-e2e-regression-and-fix, devops-ui-generate-e2e-from-feature, devops-ui-pre-setup, devops-update-containerfile-digests, devops-upgrade-go
Reviewed at 2026-04-17 02:00:41 UTC

Summary

This PR adds two missing workflow steps (NFPM Build and APK Build) to the release workflow that are required for the Checksum step to succeed. The changes are straightforward and correctly positioned before the Create Checksum step. Overall the PR is well-structured and follows existing patterns in the workflow.

Review Statistics

Category Count
Critical Issues 0
Warnings 0
Suggestions 1
Files Reviewed 1

Critical Issues

Issues that MUST be addressed before merging (security, bugs, breaking changes)

None.

Warnings

Issues that SHOULD be addressed but are not blocking

None.

Suggestions

Recommendations for improvement (nice to have)

  • [.github/workflows/release-alauda.yml:46] (style/naming): The step name "NFPM Build (deb/rpm)" includes the comment "(deb/rpm)" but the args use "nfpm-build". Consider simplifying to "NFPM Build" or making it consistent with the actual command being called.

Positive Feedback

  • The steps are added in the correct order (before Create Checksum) ensuring required directories exist
  • The implementation follows the exact same pattern as other dagger/dagger-for-github steps in the workflow (version, verb, args structure)
  • The --build-dir=./dist export --path=./dist pattern is consistent with the archive step
  • The PR description is clear and links to the failing run, making the fix easy to verify
  • No security issues detected - no hardcoded secrets, no vulnerable actions used


ℹ️ About this review

This review was automatically generated using the run-actions workflow.

  • Shared prompt: .github/prompts/code-review.md
  • Config source: centralized
  • Profile path: Not Found
  • Profile ref: 70116bce40f93e28716196a4b479fec1049b7950
  • No repository-specific prompt configured
  • Alauda skills: base-sample-email-draft, base-skill-setup, builders-component-knowledge, builders-confluence, builders-jira, builders-sample-code-review, connectors-explore, connectors-poc-case, connectors-review, connectors-unit-test, connectors-write-user-docs, devops-autodns, devops-bulk-string-replace, devops-candidate-version-supervisor, devops-docker-keyword-analysis, devops-gen-advanced-form-descriptors, devops-go-vuln-fix, devops-knowledge-adoption, devops-refresh-alauda-tags, devops-sync-alauda-github-releases, devops-tekton-dynamic-form-optimizer, devops-tekton-operator-task-e2e, devops-tekton-task-generator, devops-tekton-task-overview-template, devops-tekton-task-version-upgrade, devops-tekton-upgrade-notes, devops-ui-e2e-code-audit, devops-ui-e2e-fix-base-on-report, devops-ui-e2e-regression-and-fix, devops-ui-generate-e2e-from-feature, devops-ui-pre-setup, devops-update-containerfile-digests, devops-upgrade-go

@chengjingtao chengjingtao merged commit 7c2c3ff into alauda-v0.0.18 Apr 19, 2026
6 checks passed
@chengjingtao chengjingtao deleted the fix/release-missing-steps branch April 19, 2026 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants