ci: fix release workflow - remove apk, add PR dry-run#5
Merged
Conversation
- Remove APK build step: alauda version format (0.0.19-alauda-1) contains hyphens which are invalid in Alpine pkgver, causing "package file format error" on index creation. - Create empty dist/apk dir so DistBinaries() ls doesn't fail. - Add pull_request trigger (scoped to release/dagger/go.mod paths) so the build pipeline can be validated in PR before merging. - Guard Publish Release with `if: github.event_name != 'pull_request'` to skip actual publishing during PR validation. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
chengjingtao
force-pushed
the
fix/release-apk-and-dryrun
branch
from
916573b to
01c9e75
Compare
🤖 AI Code Review
SummaryThis PR fixes the release workflow failure due to Alpine package version constraints and adds a PR dry-run validation. The changes are minimal and correct: removing the failing APK build step, creating an empty Review Statistics
Critical Issues
None. This PR contains no critical issues. Warnings
None. This PR contains no warnings. Suggestions
Positive Feedback
ℹ️ About this reviewThis review was automatically generated using the
|
Signed-off-by: chengjingtao <chengjingtao>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix alauda release workflow failure and add PR-level validation.
Fixes
0.0.19-alauda-1contains hyphens, invalid for Alpinepkgver→package file format error. Create emptydist/apkdir instead soDistBinaries()doesn't fail onls apk.PR dry-run
pull_requesttrigger scoped to release-related paths (.github/workflows/release-alauda.yml,.dagger/**,go.mod)Publish Releasestep guarded withif: github.event_name != 'pull_request'— PR runs validatebuild → archive → nfpm → checksumwithout publishingTest plan
🤖 Generated with Claude Code