Skip to content

chore: add .catalog registration for harbor-helm#185

Open
chengjingtao wants to merge 1 commit into
alauda-1.18from
chore-add-catalog
Open

chore: add .catalog registration for harbor-helm#185
chengjingtao wants to merge 1 commit into
alauda-1.18from
chore-add-catalog

Conversation

@chengjingtao

Copy link
Copy Markdown

Summary

  • Add Backstage catalog YAML in .catalog/harbor-helm.yaml following the Confluence catalog collection standard
  • Registers harbor-helm with 10 Harbor component images (core, portal, registry, jobservice, db, redis, nginx, trivy-adapter, registryctl, exporter)
  • Includes open-source component metadata (upstream: goharbor/harbor-helm, Apache-2.0)

Test plan

  • Verify YAML passes Backstage catalog validation
  • Register in IDP dev environment and confirm component appears correctly

🤖 Generated with Claude Code

Add Backstage catalog YAML in .catalog/harbor-helm.yaml following
the Confluence catalog collection standard. Registers harbor-helm
as a service component with 10 Harbor component images.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@alaudabot

Copy link
Copy Markdown

🤖 AI Code Review

Property Value
Model opencode/minimax-m2.5-free
Style strict
Issues Found 0
Config Source centralized
Profile ❌ Not Found
Personalized Prompt ❌ No
Prompt Path .github/review/profiles/alaudadevops/harbor-helm/pr-review.md
Alauda Skills ✅ base-acp-operator-list, base-acp-operator-release, base-authoring, base-m365, base-ocp-operator-list, base-skill-setup, builders-component-knowledge, builders-confluence, builders-jira, builders-prd-to-testcase, builders-publish-errata, builders-roadmap-studio, builders-story-split, cross-repo-add-mirror, cross-repo-publish, devops-autodns, devops-candidate-version-supervisor, devops-connectors-acceptance-test, devops-connectors-explore, devops-connectors-poc-case, devops-connectors-review, devops-connectors-unit-test, devops-connectors-write-user-docs, devops-fix-go-vulns, devops-fork-alauda-binary-release, devops-gen-advanced-form-descriptors, devops-knowledge-adoption, devops-refresh-containerfile-digests, devops-refresh-containerfile-tags, devops-replace-strings, devops-scan-docker-keywords, devops-sync-alauda-github-releases, devops-tekton-dynamic-form-optimizer, devops-tekton-operator-task-e2e, devops-tekton-task-generator, devops-tekton-task-overview-template, devops-tekton-task-version-upgrade, devops-tekton-upgrade-notes, devops-tool-report-troubleshoot, devops-ui-e2e-code-audit, devops-ui-e2e-fix-base-on-report, devops-ui-e2e-regression-and-fix, devops-ui-generate-e2e-from-feature, devops-ui-pre-setup, devops-upgrade-go, devops-upstream-backport-cve, devops-upstream-upgrade
Reviewed at 2026-04-29 04:48:15 UTC

Summary

This PR adds a Backstage catalog YAML file (.catalog/harbor-helm.yaml) to register the Harbor Helm chart as a Backstage component. The YAML follows standard Backstage catalog format with proper metadata annotations for Harbor components, GitHub integration, and open-source component information. The changes are minimal (+30/-0) and structurally correct.

Review Statistics

Category Count
Critical Issues 0
Warnings 2
Suggestions 1
Files Reviewed 1

Critical Issues

Issues that MUST be addressed before merging (security, bugs, breaking changes)

None. The YAML appears syntactically correct and follows Backstage catalog conventions.

Warnings

Issues that SHOULD be addressed but are not blocking

  • [.catalog/harbor-helm.yaml:28] (style/formatting): The system value system:devops-tools has a system: prefix which may be redundant. Backstage typically uses just the system name without prefix (e.g., devops-tools). Verify this matches your organization's Backstage catalog conventions.

  • [.catalog/harbor-helm.yaml:29] (docs/verification): The owner is specified as devops. Verify this group/entity exists in your Backstage catalog (either as a group or user) before deployment, otherwise Backstage may fail to resolve references.

Suggestions

Recommendations for improvement (nice to have)

  • [.catalog/harbor-helm.yaml:27] (refactor/type-consistency): The spec.type is set to service. For Harbor Helm charts, consider if chart or helm-chart would be more descriptive, though service is acceptable if your Backstage instance treats Helm-deployed components as services.

Positive Feedback

  • Clean, well-structured Backstage catalog YAML that follows the backstage.io/v1alpha1 standard
  • Comprehensive annotations covering GitHub integration, Harbor repositories, open-source metadata (repo, version, license)
  • Proper separation of metadata (name, title, description, annotations) and spec (type, system, lifecycle, owner)
  • Includes all 10 Harbor component images in the goharbor.io/repository-slug annotation
  • Appropriate use of acp.cpaas.io/* annotations for Alauda/ACP integration

Reviewer: @OpenCode
PR: #185


ℹ️ About this review

This review was automatically generated using the run-actions workflow.

  • Shared prompt: .github/prompts/code-review.md
  • Config source: centralized
  • Profile path: Not Found
  • Profile ref: ebb6c9593926ecbd0b2b1d3ebde0c09c862ff8bf
  • No repository-specific prompt configured
  • Alauda skills: base-acp-operator-list, base-acp-operator-release, base-authoring, base-m365, base-ocp-operator-list, base-skill-setup, builders-component-knowledge, builders-confluence, builders-jira, builders-prd-to-testcase, builders-publish-errata, builders-roadmap-studio, builders-story-split, cross-repo-add-mirror, cross-repo-publish, devops-autodns, devops-candidate-version-supervisor, devops-connectors-acceptance-test, devops-connectors-explore, devops-connectors-poc-case, devops-connectors-review, devops-connectors-unit-test, devops-connectors-write-user-docs, devops-fix-go-vulns, devops-fork-alauda-binary-release, devops-gen-advanced-form-descriptors, devops-knowledge-adoption, devops-refresh-containerfile-digests, devops-refresh-containerfile-tags, devops-replace-strings, devops-scan-docker-keywords, devops-sync-alauda-github-releases, devops-tekton-dynamic-form-optimizer, devops-tekton-operator-task-e2e, devops-tekton-task-generator, devops-tekton-task-overview-template, devops-tekton-task-version-upgrade, devops-tekton-upgrade-notes, devops-tool-report-troubleshoot, devops-ui-e2e-code-audit, devops-ui-e2e-fix-base-on-report, devops-ui-e2e-regression-and-fix, devops-ui-generate-e2e-from-feature, devops-ui-pre-setup, devops-upgrade-go, devops-upstream-backport-cve, devops-upstream-upgrade

@alaudabot

Copy link
Copy Markdown

🚨 Stale Pull Request Warning

This pull request has been inactive for 33 days.

Automated Actions Schedule:

  • ⚠️ Warning: After 30 days (now)
  • 🔒 Auto-close: After 60 days
  • 🗑️ Branch deletion: After 90 days (if not protected)

To keep this PR active:

  • Add new commits
  • Reply to this comment
  • Request reviews

Protected branches (won't be deleted): main,release-*,alauda-*

This is an automated message. Reply to this comment to reset the inactivity timer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants