Skip to content

chore: update catalog registration to standard format#38

Open
kycheng wants to merge 1 commit into
mainfrom
chore/update-catalog-format
Open

chore: update catalog registration to standard format#38
kycheng wants to merge 1 commit into
mainfrom
chore/update-catalog-format

Conversation

@kycheng

@kycheng kycheng commented Apr 29, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Rename .catalog/*.yaml.catalog/catalog-info.yaml (align with tektoncd convention)
  • Add tags and links (GitHub, Harbor, SonarQube)
  • Add open-source component annotations (repo, version, license)

Test plan

  • Verify YAML passes Backstage catalog validation
  • Confirm component appears correctly in IDP

🤖 Generated with Claude Code

@alaudabot

alaudabot commented Apr 29, 2026

Copy link
Copy Markdown

🤖 AI Code Review

Property Value
Model opencode/minimax-m2.5-free
Style strict
Issues Found 0
Config Source centralized
Profile ❌ Not Found
Personalized Prompt ❌ No
Prompt Path .github/review/profiles/alaudadevops/nexus-build/pr-review.md
Alauda Skills ✅ base-acp-operator-list, base-acp-operator-release, base-authoring, base-m365, base-ocp-operator-list, base-skill-setup, builders-component-knowledge, builders-confluence, builders-jira, builders-prd-to-testcase, builders-publish-errata, builders-roadmap-studio, builders-story-split, cross-repo-add-mirror, cross-repo-publish, devops-autodns, devops-candidate-version-supervisor, devops-connectors-acceptance-test, devops-connectors-explore, devops-connectors-poc-case, devops-connectors-review, devops-connectors-unit-test, devops-connectors-upgrade-test, devops-connectors-write-user-docs, devops-fix-go-vulns, devops-fork-alauda-binary-release, devops-gen-advanced-form-descriptors, devops-knowledge-adoption, devops-refresh-containerfile-digests, devops-refresh-containerfile-tags, devops-replace-strings, devops-scan-docker-keywords, devops-sync-alauda-github-releases, devops-tekton-dynamic-form-optimizer, devops-tekton-operator-task-e2e, devops-tekton-task-generator, devops-tekton-task-overview-template, devops-tekton-task-version-upgrade, devops-tekton-upgrade-notes, devops-tool-report-troubleshoot, devops-ui-e2e-code-audit, devops-ui-e2e-fix-base-on-report, devops-ui-e2e-regression-and-fix, devops-ui-generate-e2e-from-feature, devops-ui-pre-setup, devops-upgrade-go, devops-upstream-backport-cve, devops-upstream-upgrade
Reviewed at 2026-04-29 08:37:42 UTC

Summary

This PR updates the Backstage catalog registration for the nexus-build component to standard format by adding tags, links, and open-source component metadata. The changes are primarily additive with one notable type change from plugin to service.

Review Statistics

Category Count
Critical Issues 0
Warnings 1
Suggestions 1
Files Reviewed 1

Critical Issues

Issues that MUST be addressed before merging (security, bugs, breaking changes)

None identified.

Warnings

Issues that SHOULD be addressed but are not blocking

  • [.catalog/nexus-build.yaml:33] spec.type changed from plugin to service. This may break existing Backstage integrations or filtering that rely on type: plugin. Please confirm this change is intentional and won't affect existing workflows or downstream systems.

Suggestions

Recommendations for improvement (nice to have)

  • [.catalog/nexus-build.yaml:24] The version alauda-76.0 is hardcoded. Consider using a dynamic value or environment variable to avoid manual updates when releasing new versions.
  • [.catalog/nexus-build.yaml:29] The owner uses a personal email kychen@alauda.io. Consider using a team/group reference (e.g., group:devops) for better long-term maintenance as team membership changes.

Positive Feedback

  • Good use of standard Backstage catalog format with tags and links sections
  • Proper open-source component metadata annotations following ACP conventions
  • Added relevant icons (github, dashboard) for the links
  • Comprehensive annotations covering GitHub, Harbor, and open-source component information

ℹ️ About this review

This review was automatically generated using the run-actions workflow.

  • Shared prompt: .github/prompts/code-review.md
  • Config source: centralized
  • Profile path: Not Found
  • Profile ref: ebb6c9593926ecbd0b2b1d3ebde0c09c862ff8bf
  • No repository-specific prompt configured
  • Alauda skills: base-acp-operator-list, base-acp-operator-release, base-authoring, base-m365, base-ocp-operator-list, base-skill-setup, builders-component-knowledge, builders-confluence, builders-jira, builders-prd-to-testcase, builders-publish-errata, builders-roadmap-studio, builders-story-split, cross-repo-add-mirror, cross-repo-publish, devops-autodns, devops-candidate-version-supervisor, devops-connectors-acceptance-test, devops-connectors-explore, devops-connectors-poc-case, devops-connectors-review, devops-connectors-unit-test, devops-connectors-upgrade-test, devops-connectors-write-user-docs, devops-fix-go-vulns, devops-fork-alauda-binary-release, devops-gen-advanced-form-descriptors, devops-knowledge-adoption, devops-refresh-containerfile-digests, devops-refresh-containerfile-tags, devops-replace-strings, devops-scan-docker-keywords, devops-sync-alauda-github-releases, devops-tekton-dynamic-form-optimizer, devops-tekton-operator-task-e2e, devops-tekton-task-generator, devops-tekton-task-overview-template, devops-tekton-task-version-upgrade, devops-tekton-upgrade-notes, devops-tool-report-troubleshoot, devops-ui-e2e-code-audit, devops-ui-e2e-fix-base-on-report, devops-ui-e2e-regression-and-fix, devops-ui-generate-e2e-from-feature, devops-ui-pre-setup, devops-upgrade-go, devops-upstream-backport-cve, devops-upstream-upgrade

@kycheng kycheng force-pushed the chore/update-catalog-format branch from a26b19c to 251d397 Compare April 29, 2026 06:40
- Add tags, links (GitHub, Harbor)
- Add open-source component annotations
- Remove techdocs-ref (no docs in this repo)

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@kycheng kycheng force-pushed the chore/update-catalog-format branch from 251d397 to 172629a Compare April 29, 2026 08:36
Comment thread .catalog/nexus-build.yaml
acp.cpaas.io/open-source-component-license_url: https://github.com/AlaudaDevops/nexus-build/blob/alauda-76.0/LICENSE
acp.cpaas.io/owner: kychen@alauda.io

# 组件属性,区别是否部署时必带的核心组件,可选值为 core 和 plugin。

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warning (warning/type-change): The spec.type changed from plugin to service. This may break existing Backstage integrations or filtering that rely on type: plugin. Please confirm this change is intentional and won't affect existing workflows.

Comment thread .catalog/nexus-build.yaml
# backstage techdocs plugin
backstage.io/techdocs-ref: dir:.
# 开源组件代码仓库地址,格式:${url}/${project}/${repo}
acp.cpaas.io/open-source-component-repo: https://github.com/AlaudaDevops/nexus-build

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion (suggestion/maintenance): The version alauda-76.0 is hardcoded. Consider using a dynamic value or environment variable to avoid manual updates when releasing new versions.

@alaudabot

Copy link
Copy Markdown

🚨 Stale Pull Request Warning

This pull request has been inactive for 32 days.

Automated Actions Schedule:

  • ⚠️ Warning: After 30 days (now)
  • 🔒 Auto-close: After 60 days
  • 🗑️ Branch deletion: After 90 days (if not protected)

To keep this PR active:

  • Add new commits
  • Reply to this comment
  • Request reviews

Protected branches (won't be deleted): main,release-*,alauda-*

This is an automated message. Reply to this comment to reset the inactivity timer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants