Skip to content

chore(core): add AlaudaDevops/harbor-cli to fork versioning whitelist#16

Merged
chengjingtao merged 1 commit into
mainfrom
chore/add-harbor-cli-to-whitelist
Apr 16, 2026
Merged

chore(core): add AlaudaDevops/harbor-cli to fork versioning whitelist#16
chengjingtao merged 1 commit into
mainfrom
chore/add-harbor-cli-to-whitelist

Conversation

@chengjingtao

Copy link
Copy Markdown
Contributor

Summary

Add AlaudaDevops/harbor-cli to the github-releases packageRule whitelist in core.json5, so Renovate uses the vX.Y.Z-alauda-N versioning regex for harbor-cli fork releases — consistent with harbor-scanner-trivy, trivy, tektoncd-cli, etc.

Context

harbor-cli just got Renovate onboarding at AlaudaDevops/harbor-cli#2 on the alauda-v0.0.18 branch. Fork releases will follow the vX.Y.Z-alauda-N tag convention. Without this whitelist entry, downstream repos that depend on harbor-cli releases (via github-releases) would not know how to compare fork tags and might propose incorrect update PRs.

Test plan

  • Diff is the single line addition between harbor-scanner-trivy and git-clone
  • No downstream regression (rule only narrows behavior for this specific repo's github-releases lookups)

🤖 Generated with Claude Code

harbor-cli now maintains Alauda fork release branches (alauda-v*) and
tags using the vX.Y.Z-alauda-N scheme. Extend the github-releases
versioning rule so Renovate can correctly parse and compare these tags
when other repos depend on harbor-cli releases.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

@alaudabot alaudabot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Complete

The PR looks good. Adding to the fork versioning whitelist is a valid configuration change that follows the existing pattern.

Summary:

  • 1 file changed, +1/-0 lines
  • No critical issues, warnings, or suggestions
  • Entry is correctly placed alphabetically in the whitelist

LGTM!

@alaudabot alaudabot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Complete

The PR looks good. Adding to the fork versioning whitelist is a valid configuration change that follows the existing pattern.

Summary:

  • 1 file changed, +1/-0 lines
  • No critical issues, warnings, or suggestions
  • Entry is correctly placed alphabetically in the whitelist

LGTM!

@alaudabot alaudabot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Complete

The PR looks good. Adding AlaudaDevops/harbor-cli to the fork versioning whitelist is a valid configuration change that follows the existing pattern.

Summary:

  • 1 file changed, +1/-0 lines
  • No critical issues, warnings, or suggestions
  • Entry is correctly placed alphabetically in the whitelist

LGTM!

@alaudabot

Copy link
Copy Markdown

🤖 AI Code Review

Property Value
Model opencode/minimax-m2.5-free
Style strict
Issues Found 0
Config Source centralized
Profile ❌ Not Found
Personalized Prompt ❌ No
Prompt Path .github/review/profiles/alaudadevops/renovate-config/pr-review.md
Alauda Skills ✅ base-sample-email-draft, base-skill-setup, builders-component-knowledge, builders-confluence, builders-jira, builders-sample-code-review, connectors-explore, connectors-poc-case, connectors-review, connectors-unit-test, connectors-write-user-docs, devops-autodns, devops-bulk-string-replace, devops-candidate-version-supervisor, devops-docker-keyword-analysis, devops-gen-advanced-form-descriptors, devops-go-vuln-fix, devops-knowledge-adoption, devops-refresh-alauda-tags, devops-sync-alauda-github-releases, devops-tekton-dynamic-form-optimizer, devops-tekton-operator-task-e2e, devops-tekton-task-generator, devops-tekton-task-overview-template, devops-tekton-task-version-upgrade, devops-tekton-upgrade-notes, devops-ui-e2e-code-audit, devops-ui-e2e-fix-base-on-report, devops-ui-e2e-regression-and-fix, devops-ui-generate-e2e-from-feature, devops-ui-pre-setup, devops-update-containerfile-digests, devops-upgrade-go
Reviewed at 2026-04-16 09:56:22 UTC

Summary

This PR adds AlaudaDevops/harbor-cli to the fork versioning whitelist in core.json5, enabling Renovate to correctly parse vX.Y.Z-alauda-N version tags for harbor-cli fork releases. The change follows the existing pattern of other Alauda fork repos in the whitelist and is a straightforward, valid configuration addition.

Review Statistics

Category Count
Critical Issues 0
Warnings 0
Suggestions 0
Files Reviewed 1

Critical Issues

Issues that MUST be addressed before merging (security, bugs, breaking changes)

None

Warnings

Issues that SHOULD be addressed but are not blocking

None

Suggestions

Recommendations for improvement (nice to have)

None

Positive Feedback

  • The entry is correctly placed alphabetically between harbor-scanner-trivy and git-clone
  • The change follows the exact same format as other entries in the whitelist
  • The PR includes clear context explaining why harbor-cli needs this whitelist entry
  • No security, performance, or code quality issues identified


ℹ️ About this review

This review was automatically generated using the run-actions workflow.

  • Shared prompt: .github/prompts/code-review.md
  • Config source: centralized
  • Profile path: Not Found
  • Profile ref: 70116bce40f93e28716196a4b479fec1049b7950
  • No repository-specific prompt configured
  • Alauda skills: base-sample-email-draft, base-skill-setup, builders-component-knowledge, builders-confluence, builders-jira, builders-sample-code-review, connectors-explore, connectors-poc-case, connectors-review, connectors-unit-test, connectors-write-user-docs, devops-autodns, devops-bulk-string-replace, devops-candidate-version-supervisor, devops-docker-keyword-analysis, devops-gen-advanced-form-descriptors, devops-go-vuln-fix, devops-knowledge-adoption, devops-refresh-alauda-tags, devops-sync-alauda-github-releases, devops-tekton-dynamic-form-optimizer, devops-tekton-operator-task-e2e, devops-tekton-task-generator, devops-tekton-task-overview-template, devops-tekton-task-version-upgrade, devops-tekton-upgrade-notes, devops-ui-e2e-code-audit, devops-ui-e2e-fix-base-on-report, devops-ui-e2e-regression-and-fix, devops-ui-generate-e2e-from-feature, devops-ui-pre-setup, devops-update-containerfile-digests, devops-upgrade-go

@yuzichen12123

Copy link
Copy Markdown
Contributor

/lgtm

@edge-katanomi-app2 edge-katanomi-app2 Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Status - Ready to Merge

This PR has received 2/1 valid LGTM approvals and meets the approval threshold.

LGTM Summary:

User Permission Valid
@yuzichen12123 read

The PR is now ready for merge! 🎉

Check Runs Status - All checks are passing

This PR is ready for merge from a technical perspective!

@chengjingtao chengjingtao merged commit 3d77e0d into main Apr 16, 2026
2 checks passed
@chengjingtao chengjingtao deleted the chore/add-harbor-cli-to-whitelist branch April 16, 2026 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants