feat(roadmap-planner): W5 — rename pull_requests.epic_key to jira_key#191
Merged
Conversation
Contributor
🤖 AI Code Review
SummaryThis PR renames the Review Statistics
Critical Issues
None. Warnings
None. Suggestions
Positive Feedback
Review performed by: alaudabot ℹ️ About this reviewThis review was automatically generated using the
|
3 tasks
Misnomer cleanup from the 2026-05-19 audit (finding B8). The column was named for Epics but the linker regex pulls *any* DEVOPS-NNN key from the source branch / title — in prod 4411 linked PRs, zero point at an actual Epic (Story 2817, Bug 996, Job 199, ...). - Migration 0006_rename_epic_key_to_jira_key.sql: portable RENAME COLUMN (SQLite >=3.25 + Postgres), drops idx_pr_epic, recreates idx_pr_jira. - storage.PullRequest.EpicKey -> JiraKey, no alias. - All callers in github/gitlab sync, storage upsert, sprintCounts JOIN, and the storage round-trip test update in lock-step. The JSON tag was internal-only (no frontend / external consumer reads it; PR list endpoint never exposed it). Safe one-shot rename. Unlocks W9 (cross-pillar % rewrite uses jira_key to walk to issue components). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
danielfbm
force-pushed
the
feat/metrics-w5-jira-key-rename
branch
from
3c96cf0 to
520cc4a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Misnomer cleanup from the 2026-05-19 audit (finding B8).
Why
pull_requests.epic_keywas named for Epics but the linker regex[A-Z]+-\d+pulls any matching Jira key from the source branch / title. In a prod sample of 4411 linked PRs, the distribution was:Zero of the linked rows ever pointed at an Epic. The misnomer was load-bearing in
sprintCounts— happens to work because most sprint members are Stories.Diff
migrations/0006_rename_epic_key_to_jira_key.sqlALTER TABLE pull_requests RENAME COLUMN epic_key TO jira_key(portable: SQLite ≥3.25 + Postgres). Dropsidx_pr_epic, recreatesidx_pr_jira.storage/store.goPullRequest.EpicKey→JiraKey. No alias.storage/generic.gogithub/sync.go+gitlab/sync.gocontributions/service_extras.gosprintCountsjoin + comments.storage/store_test.goJSON tag
The tag flips from
epic_key→jira_key. We grep'dfrontend/— no consumer reads it. The PR list endpoint never exposed it; only counts are surfaced.Test plan
go test ./...— greengo vet ./...— cleanTestStoreRoundtripuses the renamed fieldUnlocks
cross_pillar_review_pctrewrite walkspull_requests.jira_key→ issue components → pillars.🤖 Generated with Claude Code