feat(rm): add branch deletion option#9
Merged
Conversation
# Current problem Removing a managed worktree always leaves its branch behind, forcing users to clean up workbox branches manually when they want the sandbox branch removed with the worktree. # Proposed solution Add an explicit --delete-branch flag to rm. Keep the default behavior of preserving branches, delete only managed branches after successful worktree removal, and map --force to force branch deletion. Cover the default, managed deletion, and unmanaged refusal paths with tests.
Owner
|
Thanks lgtm! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current problem
Removing a managed worktree always leaves its branch behind, forcing users to clean up workbox branches manually when they want the sandbox branch removed with the worktree.
Proposed solution
Add an explicit --delete-branch flag to rm. Keep the default behavior of preserving branches, delete only managed branches after successful worktree removal, and map --force to force branch deletion. Cover the default, managed deletion, and unmanaged refusal paths with tests.