Sprint 9 solution http api - #5
Merged
Merged
Conversation
irek-valiev
reviewed
Nov 21, 2025
| } | ||
|
|
||
| if (manager.addEpic(epic) == null) { | ||
| sendHasOverlaps(exchange, Endpoint.POST_NEW_EPIC, epic); |
There was a problem hiding this comment.
эпики не хранятся в prioritizedTasks и не проверяются на пересечение
| if (manager.addEpic(epic) == null) { | ||
| sendHasOverlaps(exchange, Endpoint.POST_NEW_EPIC, epic); | ||
| } else { | ||
| sendText(exchange, Endpoint.POST_NEW_EPIC,"epic adding success"); |
There was a problem hiding this comment.
после создания новой сущности, в ответе нужно сообщить присвоенное ей id, по-другому "на том конце провода" его никак не узнают
| return; | ||
| } | ||
|
|
||
| Epic epic = manager.getEpic(id); |
There was a problem hiding this comment.
метод getAllSubTasksByEpic() сам вернет null, если эпика нет, поэтому отдельно получать сам эпик не нужно
| } | ||
|
|
||
| if (manager.addSubtask(subtask) == null) { | ||
| sendHasOverlaps(exchange, Endpoint.POST_NEW_SUBTASK, subtask); |
There was a problem hiding this comment.
а почему ты решил, что именно пересечение? может там id эпика не верно указано? Нужно как-то разделить ответы метода для этих случаев
| if (manager.addSubtask(subtask) == null) { | ||
| sendHasOverlaps(exchange, Endpoint.POST_NEW_SUBTASK, subtask); | ||
| } else { | ||
| sendText(exchange, Endpoint.POST_NEW_SUBTASK,"subtask adding success"); |
| } | ||
|
|
||
| if (manager.updateSubtask(subtask) == null) { | ||
| sendNotFound(exchange, Endpoint.POST_UPDATE_SUBTASK); |
There was a problem hiding this comment.
тут аналогичная ситуация, что null можно получить в нескольких случаях
| if (manager.addTask(task) == null) { | ||
| sendHasOverlaps(exchange, Endpoint.POST_NEW_TASK, task); | ||
| } else { | ||
| sendText(exchange, Endpoint.POST_NEW_TASK,"task adding success"); |
irek-valiev
approved these changes
Nov 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.