The #50 pr author is wrong #52

Activity

1. github-actions

   added

   needs-triageMaintainer needs to evaluate (loop can't decide; too risky; external PR)Maintainer needs to evaluate (loop can't decide; too risky; external PR)

   on Sep 16, 2026
2. github-actions commented on Sep 16, 2026

   

   github-actionsbot

   on Sep 16, 2026 – with GitHub Actions

   Contributor

   More actions

   Loop triage — needs-triage (human implementation; the loop must not change its own host).

   The report is correct: PR #50's commit is falsely attributed to the unrelated real account @loop. The cause is in the loop host, so the fix is a maintainer's.

   Verified read-only

   • scripts/loop/shared/agent.mjs agentEnv() (lines 191–199) injects the commit identity under auto:

     env.GIT_AUTHOR_EMAIL = env.GIT_AUTHOR_EMAIL ?? 'loop@users.noreply.github.com';
     env.GIT_COMMITTER_EMAIL = env.GIT_COMMITTER_EMAIL ?? env.GIT_AUTHOR_EMAIL;

   • gh api users/loop → {"id":1519971,"login":"loop","type":"User","created_at":"2012-03-09T12:45:05Z"} — a real User account.
   • gh api repos/Alex1990/tiny-oss/commits/8ec1b1e… (PR chore(ci): run the Azure signer oracle in CI #50's only commit) → author_email: loop@users.noreply.github.com, gh_author: loop, gh_author_id: 1519971.

   The PR object itself is already correct — gh pr view 50 shows author: app/github-actions (is_bot: true), since the host opens PRs with GITHUB_TOKEN. Only the commit identity is wrong. #50 (task #48) is the only loop-produced PR to date; every other loop/* change was owner-authored.

   Suggested fix (maintainer's choice)

   Use an identity that cannot impersonate a third party. The consistent choice is the bot GitHub already uses to author the PR:

   • name github-actions[bot], email 41898282+github-actions[bot]@users.noreply.github.com

   (gh api 'users/github-actions%5Bbot%5D' → id 41898282, type Bot; matches apps/github-actions id 15368.) A non-existent loop-specific address such as tiny-oss-loop@users.noreply.github.com (gh api users/tiny-oss-loop → 404) also works if a distinct identity is preferred. Update the git identity row in scripts/loop/README.md (~line 256) accordingly.

   Caveat: the false attribution is already in main's history (8ec1b1e, via merged #50); this only fixes future loop commits. Re-attributing history would need a force-push, which the Main branch ruleset forbids.

   Why not ready-for-agent: the fix edits the loop host that builds every agent's environment. Per AGENTS.md (maker/checker separation) and the accepted precedent for host changes (#36, #37, #47, #49, #51), the loop is neither maker nor checker for the machinery it runs on. Routing to the maintainer inbox; the loop will not open a PR for this.
3. Alex1990

   closed this as completedon Sep 16, 2026
4. Alex1990

   removed

   needs-triageMaintainer needs to evaluate (loop can't decide; too risky; external PR)Maintainer needs to evaluate (loop can't decide; too risky; external PR)

   on Sep 16, 2026
5. Alex1990

   added a commit that references this issue on Sep 17, 2026

   chore(loop): attribute loop commits to github-actions[bot]

   ...

   f7f6897