Repository navigation
chore(loop): record what A1 structurally cannot validate - #43
Merged
Merged
Conversation
A clean observation week proves the loop is *safe*, not that it is *complete*. Several capabilities cannot run at the report boundary however long A1 lasts, and the checklist did not distinguish them from items that are merely unsampled. Conflating the two would let a clean week be read as "everything verified". Decision (2026-09-11): accept the metrics write path as unverified and make it the first item after the L2 switchover. A1 produces no loop PR, so `handleMetrics` never fires — all 3 existing acceptance rows are A0-era (`manual-local` x2, `workflow-backfill`). D30/D33 cover the shared machinery (`markTaskTerminal`, the `taskId|event|pr` dedup key) and D33 verified the no-write half live twice; the write half (`planActions`) has never executed in any host. Validating it needs `LOOP_GH_TOKEN` plus `execute_writes=true`, i.e. leaving the report boundary, which is exactly what the observation week is for avoiding. Also corrected while auditing the same list, because a stale checklist is worse than an incomplete one: - `pr-review` is unreachable too — it needs a loop PR, which A1 never produces. #39/#40/#41 were loop-*related* but not loop-*produced* (head `chore/loop-*`), so they routed to `triage`. Recorded run ids for the routes that did run. - Engine stability: 18 runs with no hang, but every one exited 0 — so the failure-classification table has never been exercised by a real failure. - D33's live verification is now recorded as the two independent instances it is (#40, #41), both with no metric row.
Contributor
Coverage
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documentation only — no behaviour change. Records a decision and repairs a checklist that had become misleading.
The decision (yours, 2026-09-11)
Accept the
metricswrite path as unverified during A1; validate it as the first item after the L2 switchover.Why it cannot be validated now: A1 produces no loop PR, so the
metricsdecision never fires andhandleMetricsnever runs. All 3 existing acceptance rows are A0-era (manual-local×2,workflow-backfill).The residual risk is smaller than it looks but not zero:
markTaskTerminal(merged →accepted, closed-unmerged →rejected)taskId|event|prdedup keyplanActionsexecuting labels/comments)Validating that last row needs
LOOP_GH_TOKENplusexecute_writes=true— i.e. leaving the report boundary, which is exactly what the observation week exists to avoid. So it becomes the first thing L2 proves.What else the audit turned up
The A1 checklist mixed two very different things under one
- [ ]: items that are merely unsampled (make the event happen and you earn the box) and items that are structurally unreachable (no amount of time helps). A clean week would have been readable as "everything verified". New section separates them:metricswrite pathpr-reviewroutechore/loop-*, notloop/<n>-*), soloopTaskOfreturned null and they routed totriage. Easy to misread as coverage.execute_writesrehearsalLOOP_GH_TOKENunset, soautocannot write even if requestedAlso corrected:
retryvs inbox) has never met a real failure.issues.opened→r-20260911-121440-v8u6; sweep →r-20260911-080231-zja0) and drops the stale A0-host sweep reference.The line worth keeping
That is what the L2 decision should be made against — not a row of green checkmarks.