Repository navigation
chore(loop): attribute loop commits to github-actions[bot] - #57
Merged
Merged
Conversation
agentEnv() injected 'tiny-oss loop <loop@users.noreply.github.com>' as the git identity under auto. That address belongs to the real, unrelated GitHub user @loop (id 1519971), so every loop commit - 8ec1b1e (PR #50) and 4d2735a/35c7312 (PR #55) - was falsely attributed to a stranger (#52, #56). Use GitHub Actions' own bot instead, the same identity the host's PR is authored by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>. A bot noreply address is not a user account, so it cannot be squatted. Only future commits change; the historical ones stay as they are.
Contributor
Author
Coverage
|
Contributor
Author
|
Loop pr-review — approve ✅ Independent check of the diff (
Gates re-run from this checkout: No L1/L2 problems. Awaiting the owner's approving review and merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #56
loop-task: #56
Why
agentEnv()injectedtiny-oss loop <loop@users.noreply.github.com>as the commit identity underauto. That address belongs to the real, unrelated GitHub user @loop (id 1519971), so every loop commit was falsely attributed to a stranger —8ec1b1e(PR #50, the instance the title cites) and4d2735a/35c7312(PR #55, the commit the body cites). Issue #52 reported the same defect but was routed to the human inbox before the norms made host changes loop work; #56 is the re-report.What
scripts/loop/shared/agent.mjs—agentEnv()now setsGIT_AUTHOR_*/GIT_COMMITTER_*to GitHub Actions' own bot:github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>. That is the same identity the host's PR is authored by (the job token opens it), and a bot noreply address is not a user account, so it cannot be squatted the way a bare login can.scripts/loop/README.md— thegit identityrow in the "What the loop relies on" table documents the new identity and why the old one was wrong.The commit itself was made with the corrected identity, so it already demonstrates the fix. Commit type is
chore(loop)per AGENTS.md — host maintenance a consumer cannot observe, so it must not usefix/feator enterCHANGELOG.md.Only future commits change:
8ec1b1eand4d2735a/35c7312are already onmain, and re-attributing history would need a force-push theMain branchruleset forbids.Verification
nodeprobe ofagentEnv():autoyields the bot identity for author and committer,reportsets neither, an explicitGIT_AUTHOR_EMAILis still respected, and the R2 keys remain stripped.gh api 'users/github-actions%5Bbot%5D'→{"id":41898282,"login":"github-actions[bot]","type":"Bot"};gh api users/loop→ real User id 1519971.pnpm lint— 0 errors (39 pre-existing warnings).pnpm fmt:check— all files formatted.pnpm build— exit 0 (all entries +.d.ts).pnpm check:types— exit 0.pnpm test:azure-oracle— all checks passed.pnpm exec vitest run --browser.headlesswithpnpm serve— 22 files passed, 231 passed / 26 skipped (integration specs skip without credentials).Review
Two-lens review (correctness/regression and standards/safety) found no L1/L2 problems; the independent
pr-reviewstage re-checks the diff.