Add emission curve averaging, render budget tracking, and diagnostics UI#114
Merged
Conversation
Particle Emitter: - Add isEmissionActive property: respects duration for non-looping emitters (isEmitting remains for authoring, isEmissionActive reflects runtime state) - Replace single-point emission curve evaluation with averageMultiplier() - Samples curve across delta step (up to 32 samples, 8 per cycle) - Prevents long frames from skipping curve features (especially looping) - Applies to both continuous emission and distance emission rate curves RenderScene / Schedule: - Add sourceParticleCount, submittedSourceParticleCount, renderBudgetSkippedSourceParticleCount to ParticleRenderSummary - Track source vs submitted particle counts for CPU and GPU batches - Expose render budget skips separately from active instance count EditorStatPanel: - Add Source / Submitted Source / Render Skips to Render Batches group - Add emitter labels (name, kind, path) to hotspot list and detail - Add authoring diagnostic rows to selected emitter section - Add hotspot signal/action/details fields - Widen hotspot name column, move entity ID to end - Add ParticleAuthoringDiagnosticsRows component EditorSceneAdapter: - hasActiveParticles() uses isEmissionActive instead of isEmitting (non-looping emitters stop driving frames after duration expires) Tests: - Add isEmissionActive tests (looping/non-looping) - Add looping emission curve averaging tests (continuous + distance) - Add render budget skip diagnostic tests - Add emitter labels hierarchy path tests - Add authoring diagnostic tests (GPU blocker, fallback, ready) - Add hotspot detail/signal/recommendation tests - Add hotspot severity sort priority test - Add non-looping particle frame-driving test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Particle Emitter:
RenderScene / Schedule:
EditorStatPanel:
EditorSceneAdapter:
Tests: