beholder fixes - #1756
Open
ImpulsiveLass wants to merge 1 commit into
Open
beholder fixes#1756ImpulsiveLass wants to merge 1 commit into
ImpulsiveLass wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You can cherry pick
-Removed a lot of camera updating from BeholderEyeEntity that added to lag (I don't believe it was needed but could be wrong)
-Sends chunks back to the player when leaving beholder view, this fixes permanently missing chunks from not being sent back to the player
-Maintains 3x3 chunks around the player when using the beholder to prevent falling through the world
-Completely blocks player movement when using the beholder (this prevents starting to walk then using the beholder and continuing to walk, you are no stopped in place (although you also can't fall**)
-Moved the camera rng to a seperate randomsource, this prevents the MASSIVE frame loss when using c2me and maybe other stuff that do funny threads
-Expanded possession disallow interact behavior to block not only use item and attack but also handleKeybinds so that mods like bettercombat cannot work around and allow you to interact with yourself (and crash) with the prev mixin
https://streamable.com/e2ova7 (demo)
I'm sure the current code is stable if used alone but this fixes a lot of stuff i get in my pack with 235 mods including fastchunkgen (c2me fork), modernfix, embeddium, bettercombat, etc etc.