Skip to content

Fix/str join takes path #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
benoit-dubreuil wants to merge 30 commits into
base: master
Choose a base branch
from
Open

Fix/str join takes path #9

benoit-dubreuil wants to merge 30 commits into from

Conversation

@benoit-dubreuil
Copy link

@benoit-dubreuil benoit-dubreuil commented Jul 4, 2022

str.join supports only strictly str parameters. Any other type results in an error, even though it might be string convertible, such as pathlib.Path.

benoit-dubreuil and others added 30 commits June 29, 2022 13:04
@benoit-dubreuil
Remove data_files entry
ba3d2e6
@benoit-dubreuil
Added default util
3bc144e
@benoit-dubreuil
Added SingularityConfig class
e260acc
@benoit-dubreuil
Format
d7d6966
@benoit-dubreuil
Integrated SingularityConfig into legacy runner
d6cf37f
@benoit-dubreuil
Format
49d6d9f
@benoit-dubreuil
Format
14481bd
@benoit-dubreuil
Added singularity exec attribute to config
0bde314
@benoit-dubreuil
Typo
8714a5e
@benoit-dubreuil
Refactored config to include singularity attr
45247c0
@benoit-dubreuil
Final integration of config in legacy runner
825e4dc
@benoit-dubreuil
Final integration of config in new runner
2240b49
@benoit-dubreuil
Removed deprecated config files
53b84fa
@benoit-dubreuil
Import SingularityConfig when importing runner pkg
19ef8c8
@benoit-dubreuil
Bumped version
d0bb89a
@benoit-dubreuil
Merge pull request #1 from benoit-dubreuil/improv/remove-top-level-co…
f5b1a30 
…nfig

Improv/remove top level config
@benoit-dubreuil
Prefixed module with _ so it has a different name than its pkg
5839e78
@benoit-dubreuil
Prefixed module with _ so it has a different name than its pkg
59019ef
@benoit-dubreuil
Prefixed module with _ so it has a different name than its pkg
73b58f8
@benoit-dubreuil
Merge pull request #2 from benoit-dubreuil/fix/modules-same-name-as-pkg
54fe017 
Fix/modules same name as pkg
@benoit-dubreuil
Bumped version
bd10859
@benoit-dubreuil
Fragment os imports
109f4b4
@benoit-dubreuil
Use import instead of import-from for os.path.basename
ec44af8
@benoit-dubreuil
Use import instead of import-from for os.path
60960b1
@benoit-dubreuil
Fixed _create_outputs name shadowing of os.path due to param path
ed2d7b6
@benoit-dubreuil
Followed recommendation to make _create_outputs static
9db96aa
@benoit-dubreuil
Merge pull request #3 from benoit-dubreuil/fix/param-import-same-names
b112af3 
Fix/param import same names
@benoit-dubreuil
Bumped version
bcf88b5
@benoit-dubreuil
Fixed str.join of Path results in an error
b786c19
@benoit-dubreuil
Fixed str.join of Path results in an error
26edbb5 
in legacy runner
benoit-dubreuil added a commit to linum-uqam/voxsim that referenced this pull request Sep 5, 2022
@benoit-dubreuil
Merge pull request AlexVCaron#9 from benoit-dubreuil/feature/modern-s…
1a6696a 
…cript-simulation-runner

Feature/modern script simulation runner
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@benoit-dubreuil