Add support for .cjs files#209
Open
Kruimeldief wants to merge 1 commit into
Open
Conversation
When WOKCommands option typescript is false, CommonJS files (.cjs) should be imported in case the project package type is module.
|
+1 with module js support WOKCommands doesn't work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, WOKC only auto-imports commands of files that end with
.jswith the WOKC optiontypescript: false. With the small change below, CommonJS files.cjswill be imported as well in case the project package has the option"type": "module".Edit: seems I forgot to switch to merge into AlexzanderFlores:dev instead of _:main and I can't edit this (I think). Either branch is fine with me, as long as it is released in the near future.
@AlexzanderFlores Seeing the number of issues and open pull-up requests, is this repository abandoned? If so, could you give someone (trustful) write access to both the dev and main branch?