Skip to content

provides fix for #219 #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mcdaddytalk wants to merge 1 commit into
base: main
Choose a base branch
from
Open

provides fix for #219 #220

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions src/SlashCommands.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,9 +90,15 @@ class SlashCommands {

const args: string[] = []

options.data.forEach(({ value }) => {
args.push(String(value))
})
for (let option of interaction.options.data) {
Copy link
Copy Markdown
Contributor

@tippfehlr tippfehlr Jun 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use a const here

Copy link
Copy Markdown
Author

@mcdaddytalk mcdaddytalk Jun 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easy enough to change. Will submit new commit

if (option.type === 'SUB_COMMAND' || option.type === 'SUB_COMMAND_GROUP') {
option.options?.forEach(({ value }) => {
Copy link
Copy Markdown
Contributor

@tippfehlr tippfehlr Jun 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like to mix forEach and for in loops but that's personal preference

args.push(String(value))
})
} else {
args.push(String(option.value))
}
}

for (const [
checkName,
Expand Down