refactor!: ♻️ drop non-type template parameter for number of modes - #226
refactor!: ♻️ drop non-type template parameter for number of modes#226robertodr wants to merge 31 commits into
Quality Gate passed
Annotations
Check warning on line 363 in cpp/include/monoprop/MonomialPropagator.h
sonarqubecloud / SonarCloud Code Analysis
Pass large object "comm" by reference to const.
See more on https://sonarcloud.io/project/issues?id=Algorithmiq_monoprop&issues=AaBIWqmFk32h2_-7beg2&open=AaBIWqmFk32h2_-7beg2&pullRequest=226
Check warning on line 300 in cpp/monoprop/detail/partition/PartitionGroup.h
sonarqubecloud / SonarCloud Code Analysis
"catch" a specific exception type.
See more on https://sonarcloud.io/project/issues?id=Algorithmiq_monoprop&issues=AaBCvxnZlJmoPshECsCs&open=AaBCvxnZlJmoPshECsCs&pullRequest=226
Check failure on line 345 in cpp/monoprop/detail/operator/SparseRowStore.h
sonarqubecloud / SonarCloud Code Analysis
"std::forward" is never called on this forwarding reference argument.
See more on https://sonarcloud.io/project/issues?id=Algorithmiq_monoprop&issues=AaBJS93Eyr92L1t8-o3V&open=AaBJS93Eyr92L1t8-o3V&pullRequest=226
Check failure on line 148 in cpp/monoprop/Bitset.h
sonarqubecloud / SonarCloud Code Analysis
Use "=default" instead of the default implementation of this special member functions.
See more on https://sonarcloud.io/project/issues?id=Algorithmiq_monoprop&issues=AaBCvx4ilJmoPshECsFw&open=AaBCvx4ilJmoPshECsFw&pullRequest=226
Check warning on line 111 in cpp/monoprop/detail/evolution/layer_build/Scan.h
sonarqubecloud / SonarCloud Code Analysis
This lambda has 35 lines, which is greater than the 20 lines authorized. Split it into several lambdas or functions, or make it a named function.
See more on https://sonarcloud.io/project/issues?id=Algorithmiq_monoprop&issues=AaBCvxzClJmoPshECsDj&open=AaBCvxzClJmoPshECsDj&pullRequest=226
Check warning on line 753 in cpp/monoprop/detail/monomial_propagator/MonomialPropagator.cpp
sonarqubecloud / SonarCloud Code Analysis
This function has 8 parameters, which is greater than the 7 authorized.
See more on https://sonarcloud.io/project/issues?id=Algorithmiq_monoprop&issues=AaBCvx3KlJmoPshECsFZ&open=AaBCvx3KlJmoPshECsFZ&pullRequest=226
Check failure on line 199 in cpp/monoprop/detail/evolution/layer_build/Scan.h
sonarqubecloud / SonarCloud Code Analysis
Refactor this function to reduce its Cognitive Complexity from 67 to the 25 allowed.
See more on https://sonarcloud.io/project/issues?id=Algorithmiq_monoprop&issues=AaBCvxzClJmoPshECsDm&open=AaBCvxzClJmoPshECsDm&pullRequest=226
Check failure on line 120 in cpp/include/monoprop/MonomialPropagator.h
sonarqubecloud / SonarCloud Code Analysis
Customize this class' destructor to participate in resource management.
See more on https://sonarcloud.io/project/issues?id=Algorithmiq_monoprop&issues=AaBDRZXX18PxM1woUi-Q&open=AaBDRZXX18PxM1woUi-Q&pullRequest=226
Check warning on line 129 in cpp/monoprop/detail/evolution/layer_build/Resolve.h
sonarqubecloud / SonarCloud Code Analysis
Refactor this loop so that it is less error-prone.
See more on https://sonarcloud.io/project/issues?id=Algorithmiq_monoprop&issues=AaBCvxy1lJmoPshECsDe&open=AaBCvxy1lJmoPshECsDe&pullRequest=226
Check warning on line 710 in cpp/monoprop/detail/evolution/layer_build/Engine.h
sonarqubecloud / SonarCloud Code Analysis
This lambda has 21 lines, which is greater than the 20 lines authorized. Split it into several lambdas or functions, or make it a named function.
See more on https://sonarcloud.io/project/issues?id=Algorithmiq_monoprop&issues=AaBCvxynlJmoPshECsDa&open=AaBCvxynlJmoPshECsDa&pullRequest=226
Check warning on line 90 in cpp/monoprop/detail/evolution/layer_build/Scan.h
sonarqubecloud / SonarCloud Code Analysis
This function has 12 parameters, which is greater than the 7 authorized.
See more on https://sonarcloud.io/project/issues?id=Algorithmiq_monoprop&issues=AaBCvxzClJmoPshECsDi&open=AaBCvxzClJmoPshECsDi&pullRequest=226
Check failure on line 62 in cpp/monoprop/detail/operator/InvertedIndex.h
sonarqubecloud / SonarCloud Code Analysis
Add a mutable mutex to struct 'InvertedIndex' to guard the mutable field 'row_parity_'.
See more on https://sonarcloud.io/project/issues?id=Algorithmiq_monoprop&issues=AaBCvx2BlJmoPshECsD2&open=AaBCvx2BlJmoPshECsD2&pullRequest=226
Check warning on line 1013 in cpp/monoprop/detail/monomial_propagator/MonomialPropagator.cpp
sonarqubecloud / SonarCloud Code Analysis
This lambda has 26 lines, which is greater than the 20 lines authorized. Split it into several lambdas or functions, or make it a named function.
See more on https://sonarcloud.io/project/issues?id=Algorithmiq_monoprop&issues=AaBIWqibk32h2_-7beg0&open=AaBIWqibk32h2_-7beg0&pullRequest=226
Check failure on line 404 in cpp/monoprop/detail/evolution/layer_build/Scan.h
sonarqubecloud / SonarCloud Code Analysis
Refactor this code to not nest more than 3 if|for|do|while|switch statements.
See more on https://sonarcloud.io/project/issues?id=Algorithmiq_monoprop&issues=AaBCvxzClJmoPshECsDp&open=AaBCvxzClJmoPshECsDp&pullRequest=226
Check warning on line 138 in cpp/monoprop/detail/evolution/layer_build/Resolve.h
sonarqubecloud / SonarCloud Code Analysis
Refactor this loop so that it is less error-prone.
See more on https://sonarcloud.io/project/issues?id=Algorithmiq_monoprop&issues=AaBCvxy1lJmoPshECsDd&open=AaBCvxy1lJmoPshECsDd&pullRequest=226
Check warning on line 174 in cpp/monoprop/detail/evolution/layer_build/Resolve.h
sonarqubecloud / SonarCloud Code Analysis
This function has 8 parameters, which is greater than the 7 authorized.
See more on https://sonarcloud.io/project/issues?id=Algorithmiq_monoprop&issues=AaBCvxy1lJmoPshECsDh&open=AaBCvxy1lJmoPshECsDh&pullRequest=226
Check warning on line 337 in cpp/monoprop/detail/evolution/layer_build/Common.h
sonarqubecloud / SonarCloud Code Analysis
This function should be declared "const".
See more on https://sonarcloud.io/project/issues?id=Algorithmiq_monoprop&issues=AaBCvxyYlJmoPshECsC_&open=AaBCvxyYlJmoPshECsC_&pullRequest=226
Check warning on line 199 in cpp/monoprop/detail/evolution/layer_build/Scan.h
sonarqubecloud / SonarCloud Code Analysis
This function has 13 parameters, which is greater than the 7 authorized.
See more on https://sonarcloud.io/project/issues?id=Algorithmiq_monoprop&issues=AaBCvxzClJmoPshECsDq&open=AaBCvxzClJmoPshECsDq&pullRequest=226
Check warning on line 220 in cpp/monoprop/detail/monomial_propagator/MonomialPropagator.cpp
sonarqubecloud / SonarCloud Code Analysis
Pass large object "comm" by reference to const.
See more on https://sonarcloud.io/project/issues?id=Algorithmiq_monoprop&issues=AaBCvx3KlJmoPshECsFH&open=AaBCvx3KlJmoPshECsFH&pullRequest=226
Check failure on line 151 in cpp/monoprop/detail/operator/OperatorIndex.h
sonarqubecloud / SonarCloud Code Analysis
Replace this use of "void *" with a more meaningful type.
See more on https://sonarcloud.io/project/issues?id=Algorithmiq_monoprop&issues=AaBCvx2mlJmoPshECsE6&open=AaBCvx2mlJmoPshECsE6&pullRequest=226
Check warning on line 530 in cpp/monoprop/detail/evolution/layer_build/Engine.h
sonarqubecloud / SonarCloud Code Analysis
Refactor this loop so that it is less error-prone.
See more on https://sonarcloud.io/project/issues?id=Algorithmiq_monoprop&issues=AaBCvxynlJmoPshECsDQ&open=AaBCvxynlJmoPshECsDQ&pullRequest=226
Check warning on line 119 in cpp/monoprop/Bitset.h
sonarqubecloud / SonarCloud Code Analysis
Class has 41 methods, which is greater than the 35 authorized. Split it into smaller classes.
See more on https://sonarcloud.io/project/issues?id=Algorithmiq_monoprop&issues=AaBCvx4ilJmoPshECsFv&open=AaBCvx4ilJmoPshECsFv&pullRequest=226
Check warning on line 326 in cpp/monoprop/detail/operator/SparseRowStore.h
sonarqubecloud / SonarCloud Code Analysis
Reduce verbosity with "using enum" for "monoprop::detail::SparseRowStore::CodesWidth".
See more on https://sonarcloud.io/project/issues?id=Algorithmiq_monoprop&issues=AaBJS93Eyr92L1t8-o3U&open=AaBJS93Eyr92L1t8-o3U&pullRequest=226
Check failure on line 135 in cpp/monoprop/detail/evolution/layer_build/Engine.h
sonarqubecloud / SonarCloud Code Analysis
Add a nested comment explaining why this method is empty, or complete the implementation.
See more on https://sonarcloud.io/project/issues?id=Algorithmiq_monoprop&issues=AaBCvxynlJmoPshECsDB&open=AaBCvxynlJmoPshECsDB&pullRequest=226
Check warning on line 294 in cpp/monoprop/detail/evolution/layer_build/Scan.h
sonarqubecloud / SonarCloud Code Analysis
This lambda has 27 lines, which is greater than the 20 lines authorized. Split it into several lambdas or functions, or make it a named function.
See more on https://sonarcloud.io/project/issues?id=Algorithmiq_monoprop&issues=AaBCvxzClJmoPshECsDr&open=AaBCvxzClJmoPshECsDr&pullRequest=226