Skip to content

refactor(cpp)!: ♻️ take the mode count as a runtime width - #308

Open
robertodr wants to merge 1 commit into
split/04-sparse-row-storefrom
split/05-drop-nttp
Open

refactor(cpp)!: ♻️ take the mode count as a runtime width#308
robertodr wants to merge 1 commit into
split/04-sparse-row-storefrom
split/05-drop-nttp

refactor(cpp)!: ♻️ take the mode count as a runtime width

e89a79e
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Aug 29, 2026 in 2m 55s

Annotations

Check warning on line 617 in cpp/monoprop/detail/evolution/layer_build/Engine.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This lambda has 96 lines, which is greater than the 20 lines authorized. Split it into several lambdas or functions, or make it a named function.

See more on https://sonarcloud.io/project/issues?id=Algorithmiq_monoprop&issues=AaBOcN61r2ax2FM6Cv0v&open=AaBOcN61r2ax2FM6Cv0v&pullRequest=308

Check warning on line 363 in cpp/include/monoprop/MonomialPropagator.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Pass large object "comm" by reference to const.

See more on https://sonarcloud.io/project/issues?id=Algorithmiq_monoprop&issues=AaBOcOASr2ax2FM6Cv06&open=AaBOcOASr2ax2FM6Cv06&pullRequest=308

Check failure on line 85 in cpp/monoprop/detail/operator/MPOperator.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add a mutable mutex to struct 'MPOperator' to guard the mutable field 'inverted_index_'.

See more on https://sonarcloud.io/project/issues?id=Algorithmiq_monoprop&issues=AaBOcN06r2ax2FM6Cv0f&open=AaBOcN06r2ax2FM6Cv0f&pullRequest=308

Check failure on line 130 in cpp/monoprop/detail/evolution/layer_build/Engine.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add a nested comment explaining why this method is empty, or complete the implementation.

See more on https://sonarcloud.io/project/issues?id=Algorithmiq_monoprop&issues=AaBOcN61r2ax2FM6Cv0s&open=AaBOcN61r2ax2FM6Cv0s&pullRequest=308

Check warning on line 368 in cpp/include/monoprop/MonomialPropagator.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Pass large object "comm" by reference to const.

See more on https://sonarcloud.io/project/issues?id=Algorithmiq_monoprop&issues=AaBOcOASr2ax2FM6Cv07&open=AaBOcOASr2ax2FM6Cv07&pullRequest=308

Check failure on line 150 in cpp/monoprop/detail/operator/OperatorIndex.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this use of "void *" with a more meaningful type.

See more on https://sonarcloud.io/project/issues?id=Algorithmiq_monoprop&issues=AaBOcN45r2ax2FM6Cv0g&open=AaBOcN45r2ax2FM6Cv0g&pullRequest=308

Check warning on line 90 in cpp/monoprop/detail/evolution/layer_build/Scan.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This function has 12 parameters, which is greater than the 7 authorized.

See more on https://sonarcloud.io/project/issues?id=Algorithmiq_monoprop&issues=AaBOcN9Nr2ax2FM6Cv0y&open=AaBOcN9Nr2ax2FM6Cv0y&pullRequest=308

Check failure on line 120 in cpp/include/monoprop/MonomialPropagator.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Member variables should not be "protected".

See more on https://sonarcloud.io/project/issues?id=Algorithmiq_monoprop&issues=AaBOcOASr2ax2FM6Cv04&open=AaBOcOASr2ax2FM6Cv04&pullRequest=308

Check warning on line 120 in cpp/include/monoprop/MonomialPropagator.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Class has 85 methods, which is greater than the 35 authorized. Split it into smaller classes.

See more on https://sonarcloud.io/project/issues?id=Algorithmiq_monoprop&issues=AaBOcOASr2ax2FM6Cv05&open=AaBOcOASr2ax2FM6Cv05&pullRequest=308

Check warning on line 219 in cpp/monoprop/detail/evolution/layer_build/Scan.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This function has 13 parameters, which is greater than the 7 authorized.

See more on https://sonarcloud.io/project/issues?id=Algorithmiq_monoprop&issues=AaBOcN9Nr2ax2FM6Cv01&open=AaBOcN9Nr2ax2FM6Cv01&pullRequest=308

Check failure on line 85 in cpp/monoprop/detail/operator/MPOperator.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make mutable field 'inverted_index_' private to allow controlling all accesses and enforcing proper synchronization.

See more on https://sonarcloud.io/project/issues?id=Algorithmiq_monoprop&issues=AaBOcN06r2ax2FM6Cv0e&open=AaBOcN06r2ax2FM6Cv0e&pullRequest=308

Check warning on line 220 in cpp/monoprop/detail/monomial_propagator/MonomialPropagator.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Pass large object "comm" by reference to const.

See more on https://sonarcloud.io/project/issues?id=Algorithmiq_monoprop&issues=AaBOcN5dr2ax2FM6Cv0m&open=AaBOcN5dr2ax2FM6Cv0m&pullRequest=308

Check failure on line 264 in cpp/monoprop/detail/evolution/layer_build/Common.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add a mutable mutex to class 'DenseQueryKeys' to guard the mutable field 'view_'.

See more on https://sonarcloud.io/project/issues?id=Algorithmiq_monoprop&issues=AaBOcN6Pr2ax2FM6Cv0r&open=AaBOcN6Pr2ax2FM6Cv0r&pullRequest=308

Check failure on line 120 in cpp/include/monoprop/MonomialPropagator.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Customize this class' destructor to participate in resource management.

See more on https://sonarcloud.io/project/issues?id=Algorithmiq_monoprop&issues=AaBOcOASr2ax2FM6Cv08&open=AaBOcOASr2ax2FM6Cv08&pullRequest=308

Check warning on line 337 in cpp/monoprop/detail/evolution/layer_build/Engine.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This function has 9 parameters, which is greater than the 7 authorized.

See more on https://sonarcloud.io/project/issues?id=Algorithmiq_monoprop&issues=AaBOcN61r2ax2FM6Cv0t&open=AaBOcN61r2ax2FM6Cv0t&pullRequest=308

Check failure on line 151 in cpp/monoprop/detail/operator/OperatorIndex.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this use of "void *" with a more meaningful type.

See more on https://sonarcloud.io/project/issues?id=Algorithmiq_monoprop&issues=AaBOcN45r2ax2FM6Cv0h&open=AaBOcN45r2ax2FM6Cv0h&pullRequest=308

Check warning on line 53 in cpp/monoprop/detail/monomial_propagator/MonomialPropagator.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Pass large object "basis_change" by reference to const.

See more on https://sonarcloud.io/project/issues?id=Algorithmiq_monoprop&issues=AaBOcN5dr2ax2FM6Cv0j&open=AaBOcN5dr2ax2FM6Cv0j&pullRequest=308

Check warning on line 44 in cpp/monoprop/detail/monomial_propagator/MonomialPropagator.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This function has 13 parameters, which is greater than the 7 authorized.

See more on https://sonarcloud.io/project/issues?id=Algorithmiq_monoprop&issues=AaBOcN5dr2ax2FM6Cv0k&open=AaBOcN5dr2ax2FM6Cv0k&pullRequest=308

Check warning on line 107 in cpp/monoprop/detail/monomial_propagator/MonomialPropagator.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This lambda has 23 lines, which is greater than the 20 lines authorized. Split it into several lambdas or functions, or make it a named function.

See more on https://sonarcloud.io/project/issues?id=Algorithmiq_monoprop&issues=AaBOcN5dr2ax2FM6Cv0l&open=AaBOcN5dr2ax2FM6Cv0l&pullRequest=308

Check warning on line 111 in cpp/monoprop/detail/evolution/layer_build/Scan.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This lambda has 35 lines, which is greater than the 20 lines authorized. Split it into several lambdas or functions, or make it a named function.

See more on https://sonarcloud.io/project/issues?id=Algorithmiq_monoprop&issues=AaBOcN9Nr2ax2FM6Cv0z&open=AaBOcN9Nr2ax2FM6Cv0z&pullRequest=308

Check warning on line 308 in cpp/monoprop/detail/evolution/layer_build/Scan.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This lambda has 30 lines, which is greater than the 20 lines authorized. Split it into several lambdas or functions, or make it a named function.

See more on https://sonarcloud.io/project/issues?id=Algorithmiq_monoprop&issues=AaBOcN9Nr2ax2FM6Cv02&open=AaBOcN9Nr2ax2FM6Cv02&pullRequest=308

Check failure on line 225 in cpp/monoprop/detail/evolution/layer_build/Common.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add a nested comment explaining why this method is empty, or complete the implementation.

See more on https://sonarcloud.io/project/issues?id=Algorithmiq_monoprop&issues=AaBOcN6Pr2ax2FM6Cv0p&open=AaBOcN6Pr2ax2FM6Cv0p&pullRequest=308

Check warning on line 638 in cpp/monoprop/detail/evolution/layer_build/Engine.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This lambda has 27 lines, which is greater than the 20 lines authorized. Split it into several lambdas or functions, or make it a named function.

See more on https://sonarcloud.io/project/issues?id=Algorithmiq_monoprop&issues=AaBOcN61r2ax2FM6Cv0x&open=AaBOcN61r2ax2FM6Cv0x&pullRequest=308

Check warning on line 623 in cpp/monoprop/detail/evolution/layer_build/Engine.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This lambda has 31 lines, which is greater than the 20 lines authorized. Split it into several lambdas or functions, or make it a named function.

See more on https://sonarcloud.io/project/issues?id=Algorithmiq_monoprop&issues=AaBOcN61r2ax2FM6Cv0w&open=AaBOcN61r2ax2FM6Cv0w&pullRequest=308

Check warning on line 753 in cpp/monoprop/detail/monomial_propagator/MonomialPropagator.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This function has 8 parameters, which is greater than the 7 authorized.

See more on https://sonarcloud.io/project/issues?id=Algorithmiq_monoprop&issues=AaBOcN5dr2ax2FM6Cv0o&open=AaBOcN5dr2ax2FM6Cv0o&pullRequest=308