Repository navigation
Separate schedule queue ownership from reviewer conflicts - #55
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Schedule-set review rejected independent oversight chairs because it expanded Team-owned Obligation queues into every member. Share the existing Control collection distinction: Team membership and chairing a work queue do not establish individual operational responsibility. Personal and Appointment schedule assignments remain conflicts, while Control ownership still expands Teams and Appointments. Governed content self-approval rules stay unchanged.
Regression tests cover two-person oversight, mixed-role Teams, personal and Appointment conflicts, Team-owned implementation, strict governed-content separation, browser eligibility, CLI review preview, and saved review validation. Release 0.17.2 coordinates both packages.
Validation: two independent combined code/security reviews clean; Node 24.11.1
npm ciandCI=true npm run validate; both package inspections;npm audit; private-source/secret scans; fresh generated consumer validates 224 records without diagnostics. Playwright approved the generic Team-owned schedule with its independent chair, verified unchanged ownership/membership, and rejected that reviewer after assigning Control ownership. Browser console/network and app logs were clean. An isolated model 12 copy of the 56-Obligation workspace confirms the independent reviewer is eligible, the operator remains conflicted, and all record ownership and membership remain unchanged.Landed at
283cdfbb5ebbbb12f5d57b5fbc4431b16f9dff98. PR validation and release publication passed, including installed README setup. Release 0.17.2 publishes both packages as npmlatestwith provenance bound to the release tag. Main and the tag resolve to the same commit.