Repository navigation
Fix first occurrence reconciliation with null revisions - #66
Merged
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first
reconcile-obligationscaffold containsrevision: nullbecause no occurrence exists yet. Applying it failed in the shared mutation parser and then the CLI revision check. Treat null as an absent revision and require an occurrence revision only when updating or superseding an existing record. Domain revision checks continue rejecting missing and stale updates.Regression coverage consumes the actual CLI scaffold through creation, update, and supersession, including missing and stale revisions. Parser coverage checks null, absent, malformed, and required revisions.
Validation: Node 24.11.1,
npm ci,CI=true npm run validate, 17 focused tests, both package dry runs, andgit diff --checkpassed. A fresh local app passed a Playwright check of the shared create API with a null revision, with no page errors or failed requests; the instance was stopped. Two independent combined code and security review passes found no actionable issues.